Project

General

Profile

Actions

Feature #469

closed

Code Review/Approve workflow?

Added by Frank DePinho over 16 years ago. Updated about 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues workflow
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Duplicate

Description

Any plans on adding features similar to http://www.review-board.org/ where if enabled, code submitted can be reviewed
and commented with approval or discussion before being committed to the main repository?

Thoughts?


Related issues

Related to Redmine - Feature #7747: Add capability to ask\accept\reject review of patches (flag support on attachments)New2011-03-01

Actions
Is duplicate of Redmine - Feature #2048: Code Review ModuleNew2008-10-18

Actions
Actions #1

Updated by Jean-Philippe Lang over 16 years ago

Hi, it looks interesting.

In the near time, what can be done is:
- to create a tracker called "Review request" with
appropriate workflow which would be used to submit and comment
patches
- add a diff viewer for attachments (the code already exists
for repository diffs), so that attached patches can be easily
reviewed

Then the submitter create a "Review request" issue
and attach its patch to it. Reviewers would be able to view the
diff (just like you see diffs in the repository browser) and
enter their comments by adding notes to the issue.

What do you think ?

Actions #2

Updated by Toshi MARUYAMA about 13 years ago

  • Category set to Issues workflow
Actions #3

Updated by Daniel Felix about 11 years ago

Jean-Philippe Lang wrote:

- add a diff viewer for attachments (the code already exists
for repository diffs), so that attached patches can be easily
reviewed

This would be interessting!

Actions #4

Updated by Daniel Felix about 11 years ago

  • Subject changed from Code Review/Approce workflow? to Code Review/Approve workflow?
Actions #5

Updated by Toshi MARUYAMA about 11 years ago

Is this issue close as duplicate #2048?

Actions #6

Updated by Daniel Felix about 11 years ago

Well I would prefer to close the older one as the newer one has a better history and is more general in naming of the review tools. What do you think?

Both seem to be the same request.

Actions #7

Updated by Toshi MARUYAMA about 11 years ago

#2048 has many watchers.
I think it is better to close this issue.

Actions #8

Updated by Daniel Felix about 11 years ago

  • Status changed from New to Closed
  • Resolution set to Duplicate

Closed as duplicate of #2048.

Actions

Also available in: Atom PDF