Redmine

If this updates adds an empty file, I can't reproduce the issue.

This is because of source:trunk/app/models/attachment.rb#L147

Attachments with size zero are explicitly ignored.

Any reason for not uploading null-sized attachments, or on the other hand any reason for wanting to upload null-sized files?

We want to upload google verification files - files with special name and zero size

IIRC google verification files have to live in the root of the URI you want to verify, for that you'd need to put the file in redmine_dir/public/.

I may not correctly put. I don't wont to verify my Redmine. I want to verify my another website and add google verification file to task in Redmine. But i can't add this file to task because it has zero size.
P.S. Sorry for my English

Well, you could just save the filename in a wiki or wherever, and I think google retains means to download the files even long after they have been activated ;-)

Anyway, Holger, do you see any reason to not allow zero-sized files?

I still do not see the point why you would want that. Also, the file you downloaded from google is not a zero byte file. It at least contains the code that is also present in the filename.

But I see no technical reasons why a zero byte file would not be possible, apart from possibly obscure browser bugs of course. Also, I just traced the code back to the initial revision, so we can also safely fall back to "we always did it that way" :) See source:trunk/redmine/app/controllers/documents_controller.rb@4#L46

Felix Schäfer wrote:

Any reason for not uploading null-sized attachments, or on the other hand any reason for wanting to upload null-sized files?

Figured I would add another use-case as an example and why I went looking to see if this bug was already filed. Over the past month or so I've been uploading 4 files when running an operation.

1. before.txt
2. operation.log
3. after.txt
4. result.diff

Where result.diff is a diff of the before.txt and the after.txt files. When there is no difference then the .diff file is empty (0b) and although I still want it uploaded to show that fact, redmine is silently ignoring the upload.

I personally would like for redmine to upload 0b files since I can't think of a good reason for it not to. But more so I would say it is a bug that it silently ignores the 0b file after showing you that it has been added to the issue.

Submitted a patch that fixes this in #23718