Redmine

Orgad,

1. Please keep this ticket for the RTL changes only, for updated of the Hebrew translation, please use a new ticket.
2. Please post patches instead of whole files.

The question for further checking was not meant to insult you. Sorry if that may have sounded so. I just want to make sure that the patches are of the known good quality. As I am unable to check it myself due to my lack of RTL language knowledge, I just ask the community :)

Regarding Mohammad's patch, the rtl stylesheet must be referenced after all other stylesheets (ses the difference between rtl-layout.patch and rtl.patch)

This is a rather difficult question (with larger boundaries as only this patch).
The question is: which parts of the stylesheets should be evaluated last (and thus has the greatest power to overwrite stuff without having to resort to !important.

1. application style
2. specific module and plugin styles
3. themes

The RTL patch then should be inserted after the module styles.

Unfortunately the theme is currently loaded first which makes it very hard to overwrite default plugin styles. However, I think the RTL style provide defaults which should be easily overwritable by plugins. If this is a problem with current core styles, I think those should be changes instead. In this sense, I consider the rtl.css as a part of application.css which should be evaluated in the same context.

It should at least appear after context menu (which it overrides)

See note 6 (Is there a normal way to reference a note?)

Holger Just and Orgad Shaneh:

I think it would be good to discuss the stylesheet load order in the forums. Based on Redmine's limited theme support, there are several edge cases that we would need to think about in order to support application, theme, rtl, and plugin styles.