Redmine

Alexander F wrote:

Just a small correction - last updated by and not just "updated by".

I've modified the issue-properties to match the precise request.

I made a patch (with tests) that implements the "Last updated by" as column in issues list. This patch should be applied after the patch from #17720 because it uses the same local as filter "Last updated by".

The patch has one limitation: sorting issues after "Last updated by" column is disabled because I wasn't able to add the sorting query to take into account the "Users display format" setting (in the plugin mentioned above, the user format for this column is hard-coded). Maybe a Redmine contributor can solve this limitation, but in my opinion the patch is useful also with this limitation.

Added a new version (add_column_last_updated_by_v2.patch) that does not contain a unnecessary change presented in the first patch.

I've uploaded a new version of the patch:
- it cleanly apply on the current trunk
- it checks for journal visibility
- fixes the limitation from the previous version of the patch (sorting by "Last updated by" column works now).

Unfortunately, I didn't do any performance test.

I think that it'll be great to deliver this issue along with #17720 and #1474 (there are at least 5 duplicate issues).

Thanks Go MAEDA for testing the patch. I've attached the fixed version. The problem was generated by the data fixtures (journals weren't loaded by query_test.rb).

Jean-Phillipe Lang, I saw in r16228 that you preferred to generate the test data directly in the tests. It is better than using the existing fixtures?

Thanks again for testing the patch. Something is wrong with my development instance.

I've attached a new version which passed the tests on both mysql and sqlite3 databases.

notroot@b8ae13776d3c:/work$ RAILS_ENV=test rake db:drop db:create && ruby test/unit/query_test.rb
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot" 
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot" 
/usr/local/bundle/gems/htmlentities-4.3.1/lib/htmlentities/mappings/expanded.rb:465: warning: duplicated key at line 466 ignored: "inodot" 
Run options: --seed 496

# Running:

..........................................................................................................................................................................................

Finished in 18.171939s, 10.2356 runs/s, 29.0008 assertions/s.

186 runs, 527 assertions, 0 failures, 0 errors, 0 skips

Thanks to Marius, the patch works fine as expected and passed all tests.
Ideally this feature whould be included in 3.4.0 along with #17720.

Feature is added, thanks for the patch Marius. I've reworked the proposed changes a bit:
- Issue#last_updated_by returns nil instead of an empty string when there's no updates
- Issue.load_visible_last_updated_by loads only the last journals instead of loading all of them
- More robust unit test (I had random test failure)
- Functional tests

For the people that want this as a plugin, this one works for me:

https://github.com/neowit/redmine_last_updated_by_column.git

In my case it didn't work.
'My Page' gives error