Defect #8628: "Related to" reference may yield circular dependency error message - Redmine

Actions

Copy link

Defect #8628

closed

"Related to" reference may yield circular dependency error message

Added by Christian Zagrodnick almost 13 years ago. Updated almost 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Issues

Target version:

3.3.0

Start date:

2011-06-16

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

The "related to" reference is neither directed nor declaring a dependency. Thus the error "This relation would create a circular dependency" seems wrong. "Related to" references should be possible in any case, should they not?

Files

Download all files

fix_issue_relations.diff (853 Bytes) fix_issue_relations.diff		Egbert van der Wal, 2014-05-12 18:10
fix_issue_relations.diff (655 Bytes) fix_issue_relations.diff		Egbert van der Wal, 2014-05-12 18:13
issue_relation_test.patch (1.82 KB) issue_relation_test.patch		Uwe Koloska, 2014-09-05 16:42

Related issues

Actions

Copy link

Updated by Jean-Baptiste Barth almost 13 years ago

Category set to Issues
Status changed from New to 7
Assignee set to Jean-Baptiste Barth
Target version set to Candidate for next major release

Agreed, definitely. I'll have a look at it since I already worked on issue relations today.

Actions

Copy link

Updated by Victor Engmark over 12 years ago

"Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from both issues to the other one of the relation.

Actions

Copy link

Updated by Christian Zagrodnick about 12 years ago

Victor Engmark wrote:

"Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from both issues to the other one of the relation.

That is the case but you could still want to build larger circles A -> B -> C -> A.

Actions

Copy link

Updated by Fares Abdullah about 12 years ago

I had the same problem -

In my case I had an issue, A. I created issue B and set it as related to A. Then I found that B was a duplicate of an existing issue, C, that someone else had created.

I marked B as a duplicate of C, and wanted to relate A to C, and got the "circular dependency" error. I had to manually go and delete the relation between A and B to be able to relate A to C, even though it should not be necessary.

"related to" should allow many different issues related together, as it is not a "dependency".

Cheers and thanks for the great application!

Actions

Copy link

Updated by Jean-Baptiste Barth almost 12 years ago

Assignee deleted (~~Jean-Baptiste Barth~~)

Actions

Copy link

Updated by Jean-Philippe Lang over 11 years ago

Status changed from 7 to New

Assigned issue with no assignee back to New status.

Actions

Copy link

Updated by Leandro Guida almost 11 years ago

Here we are having the same problem.

I have an issue A, which is "father" of the issues B and C. When I try to set that C follows B, it gives me the "circular dependency" message.

Actions

Copy link

Updated by Robin McKenzie almost 11 years ago

+1 "related to" isn't a dependency.

Having the same problem, since we upgraded to the latest version of Redmine.

I've had to advise all our devs to stop using the Related Issues functionality, as this is preventing us setting up tickets with parent/child relationships.

e.g. Create a parent ticket, and two child tickets of this. Attempt to relate the two child tickets - "This relation would create a circular dependency".

Alternatively, create two tickets and relate them to each other. Create another ticket, and then set child A to have this as its parent. Attempt to set child B to have the same parent - "Parent task is invalid".

Would it be possible to get a fix for this prioritised?

Actions

Copy link

Updated by Ralf S. almost 11 years ago

+1 for this ticket from our side to (using V2.3.1)

It would be very nice, if this fix would get high priority for the next release.

Actions

Copy link

#10

Updated by Benjamin Roberts almost 11 years ago

+1 for this issue

Environment:
Redmine version 2.3.0.stable
Ruby version 1.9.3 (i386-mingw32)
Rails version 3.2.13
Environment production
Database adapter Mysql2
Redmine plugins:
no plugin installed

Actions

Copy link

#11

Updated by Luke Purdy almost 11 years ago

+1 for this update.

At the moment I can't create any parent "summary" tasks, for any children who have following dependencies between them (as 4).

It would be helpful if this fix is included as a high priority within the next release.

Actions

Copy link

#12

Updated by Robin McKenzie over 10 years ago

Would it be possible to get some feedback as to whether this is being considered for the next release? It was originally set to "Candidate for next major release" over two years ago...

Actions

Copy link

#13

Updated by Akiko Takano about 10 years ago

+1 for this update.

Actions

Copy link

#14

Updated by Egbert van der Wal almost 10 years ago

File fix_issue_relations.diff fix_issue_relations.diff added

How can this still be open when it's such a simple fix?

I applied the attached patch to my Redmine SVN checkout to fix this. Feel free to merge it in. It basically takes the type of relations into account when traversing them and ignores 'copied_to', 'duplicates' and 'relates' relationships as these do not imply any dependency.

Actions

Copy link

#15

Updated by Egbert van der Wal almost 10 years ago

File fix_issue_relations.diff fix_issue_relations.diff added

Sorry, this was the incorrect patch. Attached is the correct version. Please remove the previous patch.

Actions

Copy link

#16

Updated by Egbert van der Wal almost 10 years ago

Just a tiny update after reading the Patch page.

The patch I submitted is against revision 13127 of the stable-2.5 branch. I just tested it against trunk, revision 13138 and it also applies cleanly.

Actions

Copy link

#17

Updated by Toshi MARUYAMA almost 10 years ago

Has duplicate Feature #14660: Excluding "related to" relation from circular dependency check added

Actions

Copy link

#18

Updated by Toshi MARUYAMA almost 10 years ago

Related to deleted (Defect #13914: Circular dependency issue when issue dependency is set)

Actions

Copy link

#19

Updated by Toshi MARUYAMA almost 10 years ago

Has duplicate Defect #13914: Circular dependency issue when issue dependency is set added

Actions

Copy link

#20

Updated by James H almost 10 years ago

Actions

Copy link

#21

Updated by Uwe Koloska over 9 years ago

What about the fix for #7320? Shouldn't the tests for r4723 and r5104 detect the problem described here?

Actions

Copy link

#22

Updated by Uwe Koloska over 9 years ago

It looks like related to has a direction!

create three tickets 1, 2, 3
create relation 1 -> 2
create relation 2 -> 3
create relation 3 -> 1 gives the circular dependency error
create relation 1 -> 3 succeeds

instead of related to you can also use in any combination:

duplicates (no error with duplicated by)
copied to (no error with copied from)

Since both are really meant to have a direction their's nothing wrong if there is a circle of all duplicates or copied to, but it should definitely not treat all relations the same.

Actions

Copy link

#23