Feature #2048
open
Code Review Module
Added by Gabriel Moreira about 16 years ago. Updated over 3 years ago.
20%
Description
Create a integrated code review module like atlassian crucible, reviewboard, rietveld, mondrian etc...
Files
| changeset_journals_v1.diff (9.78 KB) changeset_journals_v1.diff | against revsion 2824 | Aaron Soules, 2009-07-21 02:53 | |
| moz-phab.png (71.6 KB) moz-phab.png | pasquale [:dedalus], 2021-04-17 09:31 |
Related issues
Updated by Lane Roathe about 16 years ago
+1 - this would be a very good feature for those of us using Redmine for project planning/management vs simple bug tracking.
Updated by Anonymous 
Updated by
Updated by Thomas Lecavelier about 16 years ago
Should be a plugin, not a feature: redmine has to stay as lightweight as possible out of the box.
Updated by Octavian Cacina about 16 years ago
+1, A fist step: allow comments on Changesets, it would be a big improvement in this direction.
Updated by Gabriel Moreira about 16 years ago
I agree. Allow comments on Changesets is more simple to begin.
Review Board: OpenSource (
http://www.review-board.org/
Atlassian Crucible Commercial (Has more features then Review Board)
http://www.atlassian.com/software/crucible/screenshots/default.jsp
Updated by Aaron Soules almost 16 years ago
Agreed, I use redmine at work for several projects and we would benefit from repository comments. I would like to replicate the github comment system, where you can tag your comment with a specific line number. That way my team could use it as a lightweight code review system. Once that works, I would like to add a feature that allows the commiter to request reviews from other users.
Updated by 
Updated by 
Updated by
Updated by Aaron Soules over 15 years ago
- File changeset_journals_v1.diff changeset_journals_v1.diff added
- % Done changed from 0 to 20
I wrote the part for adding comments to a changesets (using the existing Journal model). I couldn't figure out how to get a checkbox to show up in the email notification prefs, but I also wrote the code that sends an email to the revision committer (and other users who have commented) when someone comments on a revision.
Please let me know what I can improve/fix, This is my first contribution to Redmine :)
I've attached my diff against r2824
Updated by Aaron Soules over 15 years ago
hmm, didn't see that code review plugin... guess this issue got a little stale :) I still like the github interface better, which is what I was going for. Any thoughts? Should this code stay outside of Redmine Core?
Updated by Anton Nepomnyaschih about 15 years ago
There is code review plugin for redmine. It looks great: http://www.redmine.org/boards/3/topics/5878
Updated by
Updated by Dipan Mehta over 11 years ago
You can use the Code Review plugin. It works very well and quite the perfect module.
Updated by rm user about 11 years ago
Dipan Mehta wrote:
You can use the Code Review plugin. It works very well and quite the perfect module.
no it's not giving accept/reject functionality and not e-mailing status to the person who commited into repository.
you can only comment on specific revision line or whole revision (not really convinient because it creates an issue per each line).
in other words: its not suitable for using in production environment.
i read a lot about gerrit/reviewboard might give it a try later.
Updated by pasquale [:dedalus] almost 5 years ago
+1
nowadays from a developer team perspective this is a must have feature.
Updated by Robert Schneider almost 5 years ago
@pasquale : there is this plugin which is compatible with version 4.0: https://www.redmine.org/plugins/redmine_code_review
Updated by pasquale [:dedalus] almost 5 years ago
Hi Robert, thanks for your answer. I was looking for something similar to Review Board core or integration.
Do you use redmine_code_review in your daily workflow with your peers?
Updated by Robert Schneider almost 5 years ago
No, I have no experience with it. Never done Code Reviews, unfortunately.
Updated by rm user almost 5 years ago
pasquale [:dedalus] wrote:
+1
nowadays from a developer team perspective this is a must have feature.
I'd recommend using gitlab with pull requests, much better for code review. Also you can integrate gitlab with redmine by disabling issues in the gitlab and linking them to your redmine installation.
Updated by pasquale [:dedalus] almost 5 years ago
GitLab Is very good, but I'm on Mercurial repositories.
Updated by pasquale [:dedalus] over 3 years ago
- File moz-phab.png moz-phab.png added
As Idea, recently bugzilla has integrated an external code review tool (Phabricator) with this approach and now a specific section is present in the issue page as show under:
A similar implementation on Redmine side, could be a great improvement\step forward for the community.