Project

General

Profile

Actions
Copy link

Defect #22975

closed

Moving a wiki page to a different project should refresh parent page list

Added by Karel Pičman over 8 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Wiki
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

When renaming a wiki page in order to move it to a different project, I change the Project in the renaming form first. But, the Parent page pick list is not updated according to the selected project. Therefore, it's not possible to set a parent from the target project and I can move it to the root only.

A wrong selection of the Parent page leads to "Parent page doesn't belong to the same project" error then.

I think that the Parent page pick list should be always filled in according to the Project selection.

Files

Download all files
wiki_renaming.png (18.6 KB) wiki_renaming.png Karel Pičman, 2016-06-03 14:34
change_the_list_of_parent_pages_when_changing_project.patch (1.77 KB) change_the_list_of_parent_pages_when_changing_project.patch Mizuki ISHIKAWA, 2018-03-07 06:30
Actions
Copy link
 #1

Updated by Jean-Philippe Lang over 8 years ago

  • Tracker changed from Feature to Defect
  • Subject changed from Moving a wiki page to a different project to Moving a wiki page to a different project should refresh parent page list
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
Actions
Copy link
 #2

Updated by Mizuki ISHIKAWA over 6 years ago

This problem still exists.
I wrote a patch to solve this problem.

When this patch is applied, the list of Parent Page will change according to Project change.

Actions
Copy link
 #3

Updated by Mischa The Evil over 6 years ago

Mizuki ISHIKAWA wrote:

I wrote a patch to solve this problem.

Nice. Thanks for sharing it here. Can you add some test coverage for this?

Actions
Copy link
 #4

Updated by Mizuki ISHIKAWA over 6 years ago

Thank you for reviewing the patch, Mischa The Evil.

Mischa The Evil wrote:

Mizuki ISHIKAWA wrote:

I wrote a patch to solve this problem.

Nice. Thanks for sharing it here. Can you add some test coverage for this?

Since there is almost no Ruby code in this patch, so I thought there was no test that could be added.
Is there a place where you can write tests from the perspective of you?

Actions
Copy link
 #5

Updated by Go MAEDA over 6 years ago

The patch swaps the positions of "Parent page" and "Project" field. Is it necessary?

Actions
Copy link
 #6

Updated by Mizuki ISHIKAWA over 6 years ago

Parent page will be changed by Project change.
If there is a “Parent page" above “Project” (current), I think there is a possibility that I do not notice that the list of “Parent page" has been changed.
If there is a "Parent page" is under "Project", I thought that I could perform an intuitive operation in order from top to bottom, so I changed it.

This change is not absolutely necessary.

Actions
Copy link
 #7

Updated by Go MAEDA over 6 years ago

  • Target version changed from Candidate for next minor release to 4.0.0

Although Jean-Philippe Lang set the target version to "Candidate for next minor release", I am setting target version to 4.0.0 because the proposed patch changes the UI (swaps the positions of "Parent page" and "Project" field).

Actions
Copy link
 #8

Updated by Go MAEDA over 6 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you for improving Redmine.

Actions
Copy link

Also available in: Atom PDF