Defect #22975
closed
Moving a wiki page to a different project should refresh parent page list
Added by Karel Pičman over 8 years ago.
Updated over 6 years ago.
Description
When renaming a wiki page in order to move it to a different project, I change the Project in the renaming form first. But, the Parent page pick list is not updated according to the selected project. Therefore, it's not possible to set a parent from the target project and I can move it to the root only.
A wrong selection of the Parent page leads to "Parent page doesn't belong to the same project" error then.
I think that the Parent page pick list should be always filled in according to the Project selection.
Files
- Tracker changed from Feature to Defect
- Subject changed from Moving a wiki page to a different project to Moving a wiki page to a different project should refresh parent page list
- Status changed from New to Confirmed
- Target version set to Candidate for next minor release
This problem still exists.
I wrote a patch to solve this problem.
When this patch is applied, the list of Parent Page will change according to Project change.
Mizuki ISHIKAWA wrote:
I wrote a patch to solve this problem.
Nice. Thanks for sharing it here. Can you add some test coverage for this?
Thank you for reviewing the patch, Mischa The Evil.
Mischa The Evil wrote:
Mizuki ISHIKAWA wrote:
I wrote a patch to solve this problem.
Nice. Thanks for sharing it here. Can you add some test coverage for this?
Since there is almost no Ruby code in this patch, so I thought there was no test that could be added.
Is there a place where you can write tests from the perspective of you?
The patch swaps the positions of "Parent page" and "Project" field. Is it necessary?
Parent page will be changed by Project change.
If there is a “Parent page" above “Project” (current), I think there is a possibility that I do not notice that the list of “Parent page" has been changed.
If there is a "Parent page" is under "Project", I thought that I could perform an intuitive operation in order from top to bottom, so I changed it.
This change is not absolutely necessary.
- Target version changed from Candidate for next minor release to 4.0.0
Although Jean-Philippe Lang set the target version to "Candidate for next minor release", I am setting target version to 4.0.0 because the proposed patch changes the UI (swaps the positions of "Parent page" and "Project" field).
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed. Thank you for improving Redmine.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by