Redmine

i’ve just tried above patch and it works fine. (Including responsive layout).
Since I made simple test for this patch, I hope this would be any help.

BTW, I’m using not Gravatar but local avatar plugin to display avatars, https://github.com/ncoders/redmine_local_avatars.
It seems this plugin does not append / override class setting, such as "gravatar-child" to second avatar icon (for assignee), so that icon for assignee does not appear at the expected position. (Not Lower right, but Upper right)

Of course, this is plugin’s reason, but if you could, please apply the same style to div.gravatar-with-child > img:nth-child(2).

hg diff public/stylesheets/application.css
diff -r f5c7cc60ead2 public/stylesheets/application.css
--- a/public/stylesheets/application.css    Tue Apr 25 17:44:08 2017 +0000
+++ b/public/stylesheets/application.css    Mon May 08 08:14:29 2017 +0900
@@ -1313,6 +1313,18 @@
   margin: 0 6px 0 0;
 }

+div.gravatar-with-child {
+  position: relative;
+}
+
+img.gravatar-child, div.gravatar-with-child > img:nth-child(2) {
+  position: absolute;
+  top: 30px;
+  left: 30px;
+  border-radius: 20%;
+  border: 2px solid rgba(255, 255, 255, 0.9);
+}

Sorry, I failed to attach the patch for UI test. I'll attache it later.

Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.
I have updated patch. Now it is compatible with the plugin.

Maeda-san, thank you for picking up my request.
As I wrote above, attach an additional ui test, I’m glad if this would be help for reviewing or release planning.
(I tested with using Chromedriver and PhantomJS)

Sincerely,

Go MAEDA wrote:

Akiko-san, thank you for adding tests and pointing out redmine_local_avatars plugin.
I have updated patch. Now it is compatible with the plugin.

I am sure that this feature is useful for most users. And the feature got many likes on Twitter: https://twitter.com/g_maeda/status/861485901389504512

Let's merge this feature into trunk along with tests by Akiko Takano. Setting target version to 3.4.0.

Patch is committed with fixed functional tests. UI tests are not appropriate for this indeed.
I've also removed the duplicate assignee avatar to clean up the display.
Thanks.