Redmine

Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?

In this way, formats like:
- logo@2x.png: it'll be restored to string
- logo@2x.us: it'll link to mailto:logo@2x.us
- logo@2x.jpg: it'll be restored to string
- logo@2x.gif: it'll be restored to string

Marius BALTEANU wrote:

Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?

I think more image extensions such as "bmp" and "jpe" should be supported. Please see source:tags/3.4.5/app/helpers/application_helper.rb#L713

  def parse_hires_images(text, project, obj, attr, only_path, options)
    text.gsub!(/src="([^"]+@(\dx)\.(bmp|gif|jpg|jpe|jpeg|png))"/i) do |m|
      filename, dpr = $1, $2
      m + " srcset=\"#{filename} #{dpr}\"" 
    end
  end

Go MAEDA wrote:

I think more image extensions such as "bmp" and "jpe" should be supported. Please see source:tags/3.4.5/app/helpers/application_helper.rb#L713

[...]

Perfect, thanks for pointing me to that line, I didn't know about it.