Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address - Redmine

Actions

Copy link

Defect #27968

closed

Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address

Added by Go MAEDA almost 7 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Text formatting

Target version:

4.0.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

Image files for HDMI monitors (e.g., MacBook Pro Retina monitors) usually have "@2x" suffix in their filename, like "logo@2x.png". If you write such filenames in issues or wiki pages, Redmine misrecognizes them as email addresses and they will have useless "mailto:" link.

Example:

logo@2x.png

is rendered as

"<a href="mailto:logo@2x.png">logo@2x.png</a>"

Files

0001-do-not-recognize-hires-images-as-email-addresses.patch (3.18 KB) 0001-do-not-recognize-hires-images-as-email-addresses.patch

Marius BĂLTEANU, 2018-04-29 09:01

Related issues

Actions

Copy link

Updated by Mischa The Evil almost 7 years ago

Related to Defect #26507: "attachment:filename" link syntax would not work if the file name contains "@" added

Actions

Copy link

Updated by Marius BĂLTEANU over 6 years ago

Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?

In this way, formats like:
- logo@2x.png: it'll be restored to string
- logo@2x.us: it'll link to mailto:logo@2x.us
- logo@2x.jpg: it'll be restored to string
- logo@2x.gif: it'll be restored to string

Actions

Copy link

Updated by Go MAEDA over 6 years ago

Marius BALTEANU wrote:

Go Maeda, what do you think about restoring only the following patterns: (.*@2x\.(png|jpg|gif|jpeg))?

I think more image extensions such as "bmp" and "jpe" should be supported. Please see source:tags/3.4.5/app/helpers/application_helper.rb#L713

  def parse_hires_images(text, project, obj, attr, only_path, options)
    text.gsub!(/src="([^"]+@(\dx)\.(bmp|gif|jpg|jpe|jpeg|png))"/i) do |m|
      filename, dpr = $1, $2
      m + " srcset=\"#{filename} #{dpr}\"" 
    end
  end