Feature #30820: Drop setting "Blind carbon copy recipients (bcc)" - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Feature #30820

closed

Drop setting "Blind carbon copy recipients (bcc)"

Added by Marius BĂLTEANU almost 6 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Email notifications

Target version:

5.0.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Description

From #26791:

BCC recipients¶

Since each user gets their own mail, we can probably remove the setting to send mails with BCC completely. If plugins want to send mails to non-user recipients, we would have to make sure to either set the recipients manually on BCC or group them appropriately. It is not a required setting in Redmine core anymore though.

I agree, the setting doesn't make any sense now.

Files

Download all files

0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch (23.8 KB) 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch		Marius BĂLTEANU, 2019-02-20 09:55
0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch (25.9 KB) 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch		Marius BĂLTEANU, 2021-04-11 10:16

Related issues

Related to Redmine - Feature #26791: Send individual notification mails per mail recipient

Closed

Jean-Philippe Lang

Actions

Related to Redmine - Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false

Closed

Go MAEDA

Actions

Related to Redmine - Feature #8516: Email notifications without the recipient treated as attempted fraud by mail clients

Closed

2011-06-03

Actions

Related to Redmine - Defect #35957: MessagesControllerTest#test_post_new test fails (trunk)

Closed

Marius BĂLTEANU

Actions

Blocks Redmine - Patch #31035: Remove redefinition of ActionMailer::LogSubscriber#deliver which is no longer necessary because of the removal of Setting.bcc_recipients

Closed

Go MAEDA

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Marius BĂLTEANU almost 6 years ago

Related to Feature #26791: Send individual notification mails per mail recipient added

Actions

Copy link

Updated by Marius BĂLTEANU almost 6 years ago

Related to Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false added

Actions

Copy link

Updated by Go MAEDA almost 6 years ago

Assignee set to Jean-Philippe Lang
Target version changed from Candidate for next major release to 4.0.2

+1
The setting has no effect since #26791 was implemented.

Actions

Copy link

Updated by Go MAEDA almost 6 years ago

Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.

Actions

Copy link

Updated by Go MAEDA almost 6 years ago

Related to Feature #8516: Email notifications without the recipient treated as attempted fraud by mail clients added

Actions

Copy link

Updated by Marius BĂLTEANU almost 6 years ago

Go MAEDA wrote:

Probably the patch also resolves #8516 because Redmine with the patch applied does not remove To field.

Agree. Also, #30787 can be closed now from my point of view if you don't refer to other problem.

Actions

Copy link

Updated by Marius BĂLTEANU almost 6 years ago

File deleted (~~0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch~~)

Actions

Copy link

Updated by Marius BĂLTEANU almost 6 years ago

File 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch added

Updated to remove bcc_recipients from settings.yml as well.

Actions

Copy link

Updated by Go MAEDA almost 6 years ago

Category set to Email notifications
Target version changed from 4.0.2 to 4.1.0

Since this patch adds a migration, I am changing the target version from 4.0.2 to 4.1.0.

Actions

Copy link

#10

Updated by Go MAEDA almost 6 years ago

Blocks Patch #31035: Remove redefinition of ActionMailer::LogSubscriber#deliver which is no longer necessary because of the removal of Setting.bcc_recipients added

Actions

Copy link

#11

Updated by Jean-Philippe Lang over 5 years ago

Target version changed from 4.1.0 to 5.0.0

Removing a setting may cause some plugins to error.
Setting it to a major release.

Actions

Copy link

#12

Updated by Marius BĂLTEANU over 3 years ago

Assignee changed from Jean-Philippe Lang to Marius BĂLTEANU

Actions

Copy link

#13

Updated by Marius BĂLTEANU over 3 years ago

File 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch 0001-Remove-setting-Blind-carbon-copy-recipients-bcc.patch added
Assignee deleted (~~Marius BĂLTEANU~~)

I've rebased the branch for the current trunk

Actions

Copy link

#14

Updated by Marius BĂLTEANU over 3 years ago

Marius BALTEANU wrote:

I've rebased the patch for the current trunk

Actions

Copy link

#15

Updated by Holger Just over 3 years ago

If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.

That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)

Actions

Copy link

#16

Updated by Marius BĂLTEANU over 3 years ago

Holger Just wrote:

If entirely removing the setting is unwanted in 4.3, maybe we can deprecate it there.

That is, we could remove any code which uses the setting but keep the setting itself available in code (possible with some deprecation warning if accessed)

The next version is 5.0.0 which will contain other removals or breaking changes. I'm in favour of removing this and in the future, indeed, we can deprecate it few versions before.

Actions

Copy link

#17