Defect #32921
closed
Rails 6: add header=present to csv tests
Added by Pavel Rosický almost 5 years ago.
Updated over 3 years ago.
Description
fixes
Failure:
IssuesControllerTest#test_index_csv_with_all_columns [/redmine/test/functional/issues_controller_test.rb:878]:
Expected: "text/csv"
Actual: "text/csv; header=present"
Files
- Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Pavel, maybe you have a clue because I can't find or understand why media_type
returns "text/csv; header=present" and not only text/csv
as is explained here.
Pavel Rosický wrote:
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.
- Category set to Rails support
- Tracker changed from Patch to Defect
- Target version deleted (
5.0.0)
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch as a part of #29914.
Also available in: Atom
PDF