Defect #32921: Rails 6: add header=present to csv tests - Redmine

Actions

Copy link

Defect #32921

closed

Rails 6: add header=present to csv tests

Added by Pavel Rosický almost 5 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Rails support

Target version:

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

fixes

Failure:
IssuesControllerTest#test_index_csv_with_all_columns [/redmine/test/functional/issues_controller_test.rb:878]:
Expected: "text/csv" 
  Actual: "text/csv; header=present"

Files

Download all files

csvheaders.patch (8.12 KB) csvheaders.patch		Pavel Rosický, 2020-01-29 23:06
csvheaders2.patch (7.9 KB) csvheaders2.patch	reverts test_index_send_nothing_if_query_is_invalid	Pavel Rosický, 2020-01-29 23:12
0001-Rails-6-add-header-present-to-csv-tests.patch (9.39 KB) 0001-Rails-6-add-header-present-to-csv-tests.patch		Marius BĂLTEANU, 2020-01-31 14:54

Related issues

Actions

Copy link

Updated by Pavel Rosický almost 5 years ago

File csvheaders2.patch csvheaders2.patch added

Actions

Copy link

Updated by Marius BĂLTEANU almost 5 years ago

Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added

Actions

Copy link

Updated by Marius BĂLTEANU almost 5 years ago

Pavel, maybe you have a clue because I can't find or understand why media_type returns "text/csv; header=present" and not only text/csv as is explained here.

Actions

Copy link

Updated by Pavel Rosický almost 5 years ago

yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017

Actions

Copy link

Updated by Marius BĂLTEANU almost 5 years ago

File 0001-Rails-6-add-header-present-to-csv-tests.patch 0001-Rails-6-add-header-present-to-csv-tests.patch added
Target version set to 5.0.0

Pavel Rosický wrote:

yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017

Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.

Actions

Copy link