Redmine

Dmitry, thanks for posting the patch. I find this feature really useful.

Regarding your proposed solution, I don't think that it's a good ideea to remove the validation from the model because it will allow setting a non visible issue if you by-pass the controller (from a plugin, for example).

I'm attaching two patches:

1. 0001-Rework-patch-from-33418.patch
Based on the existing patch, but keeping the validation in the model and also fixes some edge-case bugs (for ex: no error if you press Add without typing the issue id).

2. 0002-Allow-issue-relation-autocomplete-to-select-multiple
Adds a new JS autocomplete function that allows searching for multiple values. If the solution is good enough, I'll add a system test for it.

Updated the second patch to include a test.

Let's discuss this for 4.2.0.

Committed the patch. Thank you for improving Redmine.

I'm reopening this to discuss about the API part which is not implemented 100% correctly.

1. Request:
Currently, for bulk addition of related issues, the request should contains the ids as comma-delimited string, please see the below example (param issue_to_id):

post(
  '/issues/2/relations.xml',
  :params => {:relation => {:issue_to_id => "7, 8", :relation_type => 'relates'}}
)

I think we should accept also an array of ids:

post(
  '/issues/2/relations.xml',
  :params => {:relation => {:issue_to_id => [7, 8], :relation_type => 'relates'}}
)

The attached patch allows this.

2. Response:
Currently, the response contain only the latest relation added:

{
  "relation": {
    "id": 107,
    "issue_id": 2,
    "issue_to_id": 8,
    "relation_type": "relates",
    "delay": null
  }
}

I think the response should contain all the created relations:

{
  "relations": [
    {
      "id": 114,
      "issue_id": 2,
      "issue_to_id": 7,
      "relation_type": "relates",
      "delay": null
    },
    {
      "id": 115,
      "issue_id": 2,
      "issue_to_id": 8,
      "relation_type": "relates",
      "delay": null
    }
  ]
}

but I'm not sure how to handle the case when the response contain both successfully created relations and non-successfully relations. From what I know, we don't have this kind of mixed API response in Redmine.

I see two options:
1. We change the current implementation to be transactional. In this way, we reject the entire request if an error occurs.
2. We respond with succes if at least one relation was created successfully and we append the error messages to the response:

{
  "relations": [
    {
      "id": 114,
      "issue_id": 2,
      "issue_to_id": 7,
      "relation_type": "relates",
      "delay": null
    },
    {
      "id": 115,
      "issue_id": 2,
      "issue_to_id": 8,
      "relation_type": "relates",
      "delay": null
    }
  ],
  "errors": [
    "Related issue has already been taken: #3",
  ]
}

Any feedback is welcome!