Patch #36182
open
Show notifications for all Redmine users
Added by Mizuki ISHIKAWA about 3 years ago. Updated over 2 years ago.
0%
Description
This patch adds the feature to display text throughout the site once it has been set in Settings > Administration.
There is already a famous plugin called Redmine banner that is used by many people. https://www.redmine.org/plugins/redmine_banner
This patch only provides very simple functionality, so I think you will need the Redmine banner plugin to change the notification destination and design.
Files
| show-notifications.patch (2.89 KB) show-notifications.patch | Mizuki ISHIKAWA, 2021-11-11 05:52 | ||
| screenshot-2021-11-11-10.41.31.png (84.9 KB) screenshot-2021-11-11-10.41.31.png | Mizuki ISHIKAWA, 2021-11-11 05:53 | ||
| screenshot-2021-11-11-10.41.49.png (297 KB) screenshot-2021-11-11-10.41.49.png | Mizuki ISHIKAWA, 2021-11-11 05:53 | ||
| show-notifications-v2.patch (4.99 KB) show-notifications-v2.patch | Mizuki ISHIKAWA, 2022-06-20 05:58 | ||
| screenshot-2022-06-20-13.05.50.png (575 KB) screenshot-2022-06-20-13.05.50.png | Mizuki ISHIKAWA, 2022-06-20 06:06 | ||
| screenshot-2022-06-20-13.06.00.png (518 KB) screenshot-2022-06-20-13.06.00.png | Mizuki ISHIKAWA, 2022-06-20 06:06 | ||
| Screenshot-2022-06-24.png (160 KB) Screenshot-2022-06-24.png | Go MAEDA, 2022-06-24 10:43 | ||
| show-notifications-v3.patch (4.89 KB) show-notifications-v3.patch | Go MAEDA, 2022-06-24 10:43 |
Related issues
Updated by Go MAEDA over 2 years ago
- Target version set to Candidate for next minor release
Updated by Holger Just over 2 years ago
- Has duplicate Feature #36942: Admin status messages on every page added
Updated by C S over 2 years ago
As a info for all: https://www.redmine.org/plugins/redmine_banner works also fine with 4.2.5
Updated by Mizuki ISHIKAWA over 2 years ago
I have updated the patch.
- Change the position of the banner-text display. This will also accommodate narrow screen widths.
- Change banner text to be hidden on login page when Setting.login_required? is true.
As a info for all: https://www.redmine.org/plugins/redmine_banner works also fine with 4.2.5
The redmine_banner plugin has many features and is very useful.
This patch is intended to allow minimal banner functionality without the plugin.
Updated by Mizuki ISHIKAWA over 2 years ago
- File screenshot-2022-06-20-13.05.50.png screenshot-2022-06-20-13.05.50.png added
- File screenshot-2022-06-20-13.06.00.png screenshot-2022-06-20-13.06.00.png added
Screenshots:
Updated by Go MAEDA over 2 years ago
- File Screenshot-2022-06-24.png Screenshot-2022-06-24.png added
- File show-notifications-v3.patch show-notifications-v3.patch added
I have updated the patch.
- Place the banner above the top menu
- Change the background color to green (the same color with flash notices)
Updated by Ko Nagase over 2 years ago
+1
"flush notices" (green) color looks good !
There may be a case that a system administrator may want to emphasize a banner message more,
so it may be even better if "flush warning" (yellow) and "flush error" (red) are supported with selector.
Updated by Mizuki ISHIKAWA over 2 years ago
Go MAEDA wrote:
I have updated the patch.
- Place the banner above the top menu
- Change the background color to green (the same color with flash notices)
Thank you for improving the patch.
Looks good.
Updated by Go MAEDA over 2 years ago
Ko Nagase wrote:
There may be a case that a system administrator may want to emphasize a banner message more,
so it may be even better if "flush warning" (yellow) and "flush error" (red) are supported with selector.
Good idea!
However, in order to ship this feature as soon as possible, I think it would be better to keep the patch simple and discuss the feature to set the style of the banner in a separate issue after this patch is committed.
Updated by Ko Nagase over 2 years ago
Go MAEDA wrote:
However, in order to ship this feature as soon as possible, I think it would be better to keep the patch simple and discuss the feature to set the style of the banner in a separate issue after this patch is committed.
Okay, no problem, because I rather want to see the functionality soon. :)
Thanks for confirmation & reply !
Updated by Marius BĂLTEANU over 2 years ago
I don't think that we should commit this as it is. We should implement a proper banner/notification system with start and end dates for the messages.
Updated by Mizuki ISHIKAWA over 2 years ago
Marius BALTEANU wrote:
I don't think that we should commit this as it is. We should implement a proper banner/notification system with start and end dates for the messages.
Thank you for your feedback.
I submitted a simple patch because I thought it can be fully utilized with minimal functionality.
I also think that with the current design using the Setting table, it is easy to extend it later with additional options such as publication date and time information, display type, etc.
I would like to hear your opinion on the requirements and design of the banner/notification system.