Defect #36524

Query Links on Issues and Time Logs Import Sidebars broken

Added by Felix Schäfer 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:UI
Target version:5.0.0
Resolution:Fixed Affected version:4.2.3

Description

The import pages for issues and time logs have sidebars with links to saved issue queries and time log queries. These links are currently broken and just render as the_current_page?query_id=3, for example http://localhost:3000/issues/imports/new?query_id=7

36524-remove_import_sidebars.patch Magnifier (2.63 KB) Felix Schäfer, 2022-01-25 20:37

Associated revisions

Revision 21390
Added by Marius BALTEANU 4 months ago

Remove sidebar with invalid query links from imports views (#36524).

Patch by Felix Schäfer.

Revision 21391
Added by Marius BALTEANU 4 months ago

Remove sidebar views (#36524).

Patch by Felix Schäfer.

History

#1 Updated by Felix Schäfer 4 months ago

We have tracked down the issue to source:/trunk/app/helpers/queries_helper.rb@21387#L457, which is not aware of the issues and time logs imports, and thus can't correctly generate the query links.

Instead of trying to fix this we would like to suggest simply removing the sidebars entirely for the imports. While doing the import the query links are not of a great use because clicking on one of those links would interrupt the import steps. Furthermore, the user import for example does not have a sidebar, i.e. removing the sidebar in the other cases would be consistent. Last but not least, the new issue view for example does not have a sidebar either, probably because having links to the queries while creating something is not very helpful.

Do you think just removing the sidebar from the CSV import would be a good option here? If yes we can prepare a patch accordingly.

#2 Updated by Holger Just 4 months ago

  • Description updated (diff)

#3 Updated by Felix Schäfer 4 months ago

The attached patch removes the aforementioned sidebars.

#4 Updated by Marius BALTEANU 4 months ago

  • Status changed from New to Resolved
  • Assignee set to Marius BALTEANU
  • Target version set to 5.0.0
  • Resolution set to Fixed

Patch committed, thanks!

#5 Updated by Marius BALTEANU 4 months ago

  • Status changed from Resolved to Closed

#6 Updated by Felix Schäfer 4 months ago

Thank you!

Also available in: Atom PDF