Project

General

Profile

Actions

Defect #36524

closed

Query Links on Issues and Time Logs Import Sidebars broken

Added by Felix Schäfer about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

The import pages for issues and time logs have sidebars with links to saved issue queries and time log queries. These links are currently broken and just render as the_current_page?query_id=3, for example http://localhost:3000/issues/imports/new?query_id=7


Files

36524-remove_import_sidebars.patch (2.63 KB) 36524-remove_import_sidebars.patch Felix Schäfer, 2022-01-25 20:37

Related issues

Related to Redmine - Feature #33102: Import user accounts from CSV fileClosedGo MAEDA

Actions
Actions #1

Updated by Felix Schäfer about 2 years ago

We have tracked down the issue to source:/trunk/app/helpers/queries_helper.rb@21387#L457, which is not aware of the issues and time logs imports, and thus can't correctly generate the query links.

Instead of trying to fix this we would like to suggest simply removing the sidebars entirely for the imports. While doing the import the query links are not of a great use because clicking on one of those links would interrupt the import steps. Furthermore, the user import for example does not have a sidebar, i.e. removing the sidebar in the other cases would be consistent. Last but not least, the new issue view for example does not have a sidebar either, probably because having links to the queries while creating something is not very helpful.

Do you think just removing the sidebar from the CSV import would be a good option here? If yes we can prepare a patch accordingly.

Actions #2

Updated by Holger Just about 2 years ago

  • Description updated (diff)
Actions #3

Updated by Felix Schäfer about 2 years ago

The attached patch removes the aforementioned sidebars.

Actions #4

Updated by Marius BĂLTEANU about 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU
  • Target version set to 5.0.0
  • Resolution set to Fixed

Patch committed, thanks!

Actions #5

Updated by Marius BĂLTEANU about 2 years ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Felix Schäfer about 2 years ago

Thank you!

Actions #7

Updated by Mischa The Evil 4 months ago

Actions

Also available in: Atom PDF