Feature #8160
closedExtend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution
Added by Keidson Freitas over 13 years ago. Updated over 6 years ago.
0%
Description
When i try to use the watcher in the filter on issues, the list is only showing <<Me>>, so i can only filter issues watched by Me or not watched by Me.
Files
Add_filter_value_of_watcher.patch (2.64 KB) Add_filter_value_of_watcher.patch | Mizuki ISHIKAWA, 2018-06-25 10:12 | ||
Add_filter_value_of_watcher_v2.patch (2.76 KB) Add_filter_value_of_watcher_v2.patch | Mizuki ISHIKAWA, 2018-06-26 02:46 |
Related issues
Updated by Etienne Massip over 13 years ago
- Category set to Issues
- Target version set to Candidate for next minor release
Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
Updated by Mischa The Evil over 13 years ago
- Tracker changed from Defect to Feature
- Subject changed from The watcher filter it's only showing <<Me>> in the list to Extend watched_by_me-issue filter to include all project-members instead of only <<me>>-substitution
Etienne Massip wrote:
Same behavior on my devel instance, Redmine demo site and this site, looks like a true issue.
It's a true issue indeed, although it is not a defect looking at the way the "watched_by_me"-filter feature has been implemented in revision r2456 for feature #846; I've changed the tracker and subject accordingly.
Updated by Mischa The Evil over 13 years ago
Updated by Jean-Philippe Lang about 11 years ago
- Has duplicate Defect #15347: Issue filter does not allow filtering by any watcher except for "me" added
Updated by Benjamin Roberts almost 11 years ago
Has this really been a candidate for the next minor release for more than two years? It gets my vote if it makes a difference. =)
Updated by Koen Boone almost 11 years ago
We have 9 people here who also give their vote for this... :-/
Updated by Plam Sim over 10 years ago
The same behavior we have in Redmine 2.5.1. Do you plan to fix it? Another watcher, except "me", cannot be added to the filter. In that case the filter "Watcher is" doesn't deliver its functionality.
Updated by Quan VN over 9 years ago
It seems that this behavior is intention since even with new update redmine 2.6.6 there is no change.
So if you want to change it here is the manual patch
In app/models/issue_query.rb, find the following lines
if User.current.logged?
add_available_filter "watcher_id",
:type => :list, :values => [["<< #{l(:label_me)} >>", "me"]]
end
remove them completely and replace with
watcher_values = []
watcher_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
watcher_values += users.collect{|s| [s.name, s.id.to_s] }
add_available_filter("watcher_id",
:type => :list, :values => watcher_values
) unless watcher_values.empty?
Restart redmine and you have other members in the watcher list
Updated by Go MAEDA almost 9 years ago
- Has duplicate Feature #10912: Add search by watcher added
Updated by Aleksandar Pavic over 8 years ago
+1 (tested on 2.5.2 and 3.0.6.stable.14912)
Updated by Alessandro Zucchi about 8 years ago
Is possible have this fix in 3.3.2 version ?
It's a great limits
Thanks
Alessandro
Updated by Anonymous almost 8 years ago
We use extended_watchers plugin to allow watchers restricted issue access. This feature would be extremely helpful to get an overview who can access (=is watching) which issue.
+1
Thanks
Immanuel.
Updated by Go MAEDA about 7 years ago
- Has duplicate Defect #27123: Issue filter "watcher" dosn't show any users added
Updated by Michael Schneider about 7 years ago
I think this would be very useful.
+1
Updated by Philippe Ivaldi about 7 years ago
Michael Schneider wrote:
I think this would be very useful.
+1
+1 !
Updated by Go MAEDA over 6 years ago
- Category changed from Issues to Issues filter
Updated by Mizuki ISHIKAWA over 6 years ago
By applying this patch, only user with :view_issue_watcher permission will be able to search for project members other than yourself.
This feature seems to be needed by many people.
Updated by Alessandro Zucchi over 6 years ago
Come on, move it in 4.0! :-)
It's very usefull
Many thanks
Alessandro
Updated by Go MAEDA over 6 years ago
Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
- I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter.
:global => true
in theUser.current.allowed_to?
should be removed. - In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
Updated by Go MAEDA over 6 years ago
- Target version changed from Candidate for next minor release to Candidate for next major release
Updated by Mizuki ISHIKAWA over 6 years ago
Go MAEDA wrote:
Mizuki, thank you very much for posting the patch so quickly. I tried out the patch and I noticed the following points. To move this issue forward, could you update the patch?
- I think users who don't have view_issue_watcher permission on the project must not be able to see other users in the filter.
:global => true
in theUser.current.allowed_to?
should be removed.- In the current trunk, user type filters group users by its status (see #15201). To keep the UI consistent, I think watchers filter should use the same style.
Fixed points you pointed out.
Thank you for checking.
Updated by Marius BĂLTEANU over 6 years ago
LGTM, I'm in favour of delivering this feature in the next major version.
Updated by Marius BĂLTEANU over 6 years ago
- Related to deleted (Defect #4501: URL-mangling provides data not reachable through UI)
Updated by Go MAEDA over 6 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from Candidate for next major release to 4.0.0
- Resolution set to Fixed
Committed.
Users who have "View issues list" (:view_issue_watchers) permission can see project members in the "Watchers" filter.
Updated by Go MAEDA almost 4 years ago
- Related to Feature #34700: Allow to use watch_by filter in the global issues list added