Feature #22978
Links to issue notes should highlight the linked note
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.0.0 | |||
| Resolution: | Fixed |
Description
When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.
It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.
click_the_link.gif (318 KB)
highlight_the_linked_note.patch 
(525 Bytes)
highlight_the_linked_note-v2.patch
(555 Bytes)
highlight_the_linked_note-v3.patch
(1.14 KB)
Related issues
Associated revisions
Note URLs should highlight the linked note (#22978).
Patch by Mizuki ISHIKAWA.
Change highlight settings (#22978).
Use CSS to highlight the journal title (#22978).
Removes unused class (#22978).
History
#1
Updated by Toshi MARUYAMA about 6 years ago
- Description updated (diff)
#2
Updated by Mizuki ISHIKAWA about 5 years ago
- File click_the_link.gif added
- File highlight_the_linked_note.patch added
I wrote a patch to implement this feature.
Please see the attached gif animation: click_the_link.gif
#3
Updated by Go MAEDA about 5 years ago
- Target version set to Candidate for next major release
I am sure this feature can improve UX. Discourse (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .
The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:
--- highlight_the_linked_note.patch.org 2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch 2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
+ $(window).on('load hashchange',function(){
+ var hash = location.hash;
+ if (hash){
-+ $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++ $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
+ }
+ });
+});
#4
Updated by Robert Schneider about 5 years ago
+1 Nice improvement!
#5
Updated by Go MAEDA about 5 years ago
- File highlight_the_linked_note-v2.patch added
I slightly changed the patch. The new patch checks if the format of the fragment identifier is "#change-nnn" or "#note-nnn".
#6
Updated by Mizuki ISHIKAWA about 5 years ago
- File highlight_the_linked_note-v3.patch added
Updated my patch. Replaced a color value with a CSS class in the view.
#7
Updated by Mischa The Evil about 5 years ago
- Target version changed from Candidate for next major release to 4.1.0
#8
Updated by Yuuki NARA almost 5 years ago
+1
#9
Updated by Jean-Philippe Lang almost 5 years ago
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks. I've made the transition a bit longer and changed the color.
#10
Updated by Jean-Philippe Lang almost 5 years ago
- Subject changed from Note URLs should highlight the linked note to Links to issue notes should highlight the linked note
#11
Updated by Jean-Philippe Lang almost 5 years ago
- Target version changed from 4.1.0 to 4.0.0
#12
Updated by Robert Pollak almost 5 years ago
Thanks to everyone involved!
#13
Updated by Go MAEDA over 4 years ago
- Related to Feature #28330: Links to wiki headings should highlight the linked heading added
#14
Updated by Go MAEDA over 4 years ago
- Duplicated by Feature #15410: Highlighting of comment anchors added
#15
Updated by Go MAEDA over 3 years ago
- Related to Feature #30834: Links to forum replies should highlight the linked reply added