Project

General

Profile

Actions

Feature #22978

closed

Links to issue notes should highlight the linked note

Added by Robert Pollak over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.

It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.


Files

click_the_link.gif (318 KB) click_the_link.gif Mizuki ISHIKAWA, 2017-06-28 04:04
highlight_the_linked_note.patch (525 Bytes) highlight_the_linked_note.patch Mizuki ISHIKAWA, 2017-06-28 04:05
highlight_the_linked_note-v2.patch (555 Bytes) highlight_the_linked_note-v2.patch Go MAEDA, 2017-06-28 09:30
highlight_the_linked_note-v3.patch (1.14 KB) highlight_the_linked_note-v3.patch Mizuki ISHIKAWA, 2017-06-29 04:56

Related issues

Related to Redmine - Feature #28330: Links to wiki headings should highlight the linked headingClosedGo MAEDA

Actions
Related to Redmine - Feature #30834: Links to forum replies should highlight the linked replyClosedGo MAEDA

Actions
Has duplicate Redmine - Feature #15410: Highlighting of comment anchorsClosed

Actions
Actions #1

Updated by Toshi MARUYAMA over 7 years ago

  • Description updated (diff)
Actions #2

Updated by Mizuki ISHIKAWA over 6 years ago

I wrote a patch to implement this feature.
Please see the attached gif animation: click_the_link.gif

Actions #3

Updated by Go MAEDA over 6 years ago

  • Target version set to Candidate for next major release

I am sure this feature can improve UX. Discourse (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .

The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:

--- highlight_the_linked_note.patch.org    2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch    2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
 +  $(window).on('load hashchange',function(){
 +    var hash = location.hash;
 +    if (hash){
-+      $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++      $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
 +    }
 +  });
 +});
Actions #4

Updated by Robert Schneider over 6 years ago

+1 Nice improvement!

Actions #5

Updated by Go MAEDA over 6 years ago

I slightly changed the patch. The new patch checks if the format of the fragment identifier is "#change-nnn" or "#note-nnn".

Actions #6

Updated by Mizuki ISHIKAWA over 6 years ago

Updated my patch. Replaced a color value with a CSS class in the view.

Actions #7

Updated by Mischa The Evil over 6 years ago

  • Target version changed from Candidate for next major release to 4.1.0
Actions #8

Updated by Yuuki NARA over 6 years ago

+1

Actions #9

Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks. I've made the transition a bit longer and changed the color.

Actions #10

Updated by Jean-Philippe Lang over 6 years ago

  • Subject changed from Note URLs should highlight the linked note to Links to issue notes should highlight the linked note
Actions #11

Updated by Jean-Philippe Lang over 6 years ago

  • Target version changed from 4.1.0 to 4.0.0
Actions #12

Updated by Robert Pollak over 6 years ago

Thanks to everyone involved!

Actions #13

Updated by Go MAEDA almost 6 years ago

  • Related to Feature #28330: Links to wiki headings should highlight the linked heading added
Actions #14

Updated by Go MAEDA almost 6 years ago

Actions #15

Updated by Go MAEDA about 5 years ago

  • Related to Feature #30834: Links to forum replies should highlight the linked reply added
Actions

Also available in: Atom PDF