Feature #22978
closed
Links to issue notes should highlight the linked note
Added by Robert Pollak over 8 years ago.
Updated over 7 years ago.
Description
When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.
It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.
Files
- Description updated (diff)
I wrote a patch to implement this feature.
Please see the attached gif animation: click_the_link.gif
- Target version set to Candidate for next major release
I am sure this feature can improve UX. Discourse (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .
The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:
--- highlight_the_linked_note.patch.org 2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch 2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
+ $(window).on('load hashchange',function(){
+ var hash = location.hash;
+ if (hash){
-+ $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++ $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
+ }
+ });
+});
I slightly changed the patch. The new patch checks if the format of the fragment identifier is "#change-nnn" or "#note-nnn".
Updated my patch. Replaced a color value with a CSS class in the view.
- Target version changed from Candidate for next major release to 4.1.0
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks. I've made the transition a bit longer and changed the color.
- Subject changed from Note URLs should highlight the linked note to Links to issue notes should highlight the linked note
- Target version changed from 4.1.0 to 4.0.0
Thanks to everyone involved!
- Related to Feature #28330: Links to wiki headings should highlight the linked heading added
- Related to Feature #30834: Links to forum replies should highlight the linked reply added
Also available in: Atom
PDF