Redmine

Duplicated by #12060 #12917

+1, I'd very much welcome this feature :)

Almost none of the people I've worked with (programmers, technical people) was able to understand at first glance how to add a comment in a issue

Redmine is a great software, only it took me some time to understand on how to add a note/comment.
I would expect it to be at the bottom of the issue notes.
Great GUI rule: Don't let me read a manual.
Thanks for prioritizing this improvement.

Does anyone know if there's any plugin out there that implements this functionality?

I too would like to see this, it seems that the quote button almost handle's this.

I am desperately looking for that feature. And also the ability to display notes/comments and change history separately

Ismael Barros² wrote:

Does anyone know if there's any plugin out there that implements this functionality?

I'd like to raise my hand for this as well. It's utterly important for our organization as it's by far the most frequent confusion among users.

Also, the tiny, nearly invisible, pencil button near "Description:" should be expanded by default when updating/editing the issue.

Hi everybody,

We recently switched on Redmine and would love to have a function to add quickly a note because editing an issue to quickly add a note seems really disturbing to us. It is really usefull to take notes related to each issue so that we have all the informations and questions we had about it. What is planned for this point? Will the next release have something like this?

Thank you very much for your answer.

Best Regards, Michael

Nice to see some work being done on this issue!

I tried your patch though, and for me it only seems to reload the page. I can see in the log though that it does render it (Rendered journals/_notes_new_form.html.erb (11.4ms)).
I have verified that the patch was applied successfully, and I have tried with both the custom theme we are using and default theme and with different users (one of them admin) - with no luck. I have not made any other modifications to Redmine, save for a mylyn connector.

Environment:
Redmine version 3.2.0.stable
Ruby version 1.9.3-p484 (2013-11-22) [x86_64-linux]
Rails version 4.2.5
Environment production
Database adapter PostgreSQL
SCM:
Mercurial 2.8.2
Git 1.9.1
Filesystem
Redmine plugins:
redmine_mylyn_connector 2.8.2.stable

Oscar Edvardsson wrote:

Nice to see some work being done on this issue!

I tried your patch though, and for me it only seems to reload the page. I can see in the log though that it does render it (Rendered journals/_notes_new_form.html.erb (11.4ms)).
I have verified that the patch was applied successfully, and I have tried with both the custom theme we are using and default theme and with different users (one of them admin) - with no luck. I have not made any other modifications to Redmine, save for a mylyn connector.

Environment:
Redmine version 3.2.0.stable
Ruby version 1.9.3-p484 (2013-11-22) [x86_64-linux]
Rails version 4.2.5
Environment production
Database adapter PostgreSQL
SCM:
Mercurial 2.8.2
Git 1.9.1
Filesystem
Redmine plugins:
redmine_mylyn_connector 2.8.2.stable

The patch was developed against Revision r15317

I tested now on 3.2.1-stable and works fine. I'll try later to test the patch against version 3.2.0.stable and also against latest revision.

My Environment:
Redmine version 3.2.1.devel
Ruby version 2.2.3-p173 (2015-08-18) [x86_64-linux]
Rails version 4.2.5.2
Environment development
Database adapter Mysql2

Marius BALTEANU wrote:

I'll try later to test the patch against version 3.2.0.stable and also against latest revision.

I tested also on 3.2.0 (with and without your plugin) and works fine (Chrome and Firefox latest versions). That reload should be a POST request to /issues/<id> and you should receive a 302 redirect as response from the server (the patch uses the same post method from edit issues). I don't know how can I help you further to debug your problem, so I'll wait for someone else feedback.

Marius BALTEANU wrote:

I tested also on 3.2.0 (with and without your plugin) and works fine (Chrome and Firefox latest versions). That reload should be a POST request to /issues/<id> and you should receive a 302 redirect as response from the server (the patch uses the same post method from edit issues). I don't know how can I help you further to debug your problem, so I'll wait for someone else feedback.

I never thought of testing a different browser… Works on Chrome, but not Safari (Version 9.1 (11601.5.17.1)).

Thanks for the feedback, I'll check why the patch is not working on Safari.

I've just tested the patch on Safari Version 9.1 (11601.5.17.1) and works fine.

Odd, now it works splendidly. I did restart Redmine though, maybe that was needed...?

Oscar Edvardsson wrote:

Odd, now it works splendidly. I did restart Redmine though, maybe that was needed...?

Yes, restarting the application server is a must.

Would it be possible to have that "add note" field open by default, like the reply box in most forums (XenForo, etc.)?

For that matter, the same should happen on threads in Redmine forum...

That would make it super easy to comment on an issue

the fury wrote:

Would it be possible to have that "add note" field open by default, like the reply box in most forums (XenForo, etc.)?

For that matter, the same should happen on threads in Redmine forum...

That would make it super easy to comment on an issue

Both solutions requires one click for adding a note:
- "Add Notes" button: After you click it, the focus is set automatically on the field and you can start typing
- Field box open by default: you need to click on it to focus the field

Because of that, I would prefer the "Add notes" button.

Marius BALTEANU wrote:

the fury wrote:

Would it be possible to have that "add note" field open by default, like the reply box in most forums (XenForo, etc.)?

For that matter, the same should happen on threads in Redmine forum...

That would make it super easy to comment on an issue

Both solutions requires one click for adding a note:
- "Add Notes" button: After you click it, the focus is set automatically on the field and you can start typing
- Field box open by default: you need to click on it to focus the field

Because of that, I would prefer the "Add notes" button.

True, only a single action in both cases, but in terms of intuitive interface, if the comment field is visible by default, it makes it obvious that's where one goes to leave a comment on the issue, so people don't have to hunt around or get trained on how to use the thing. I'm faced with the task of bringing dozens of people at work on board to Redmine, where the existing "system" is email and Office docs on network shares...so really, anything's an improvement, but I'm hoping to minimize the friction against change by having the most discoverable UI possible.

Now that I look at the patch, it's just a matter of the CSS, so I could just override it in my theme. I'm cool with that, going to apply the patch now. :)

Marius BALTEANU wrote:

I've attached a patch (add_notes_button.patch) that implements this feature by adding a new button named "Add notes" to the bottom of the issue page.

I've applied the patch on my copy (I'm on 3.2.1-stable) and restarted Redmine, however the issue view now reports a 500 internal server error. I have the redmine_ckeditor plugin installed, and it looks like there is something going wonky here:

ActionView::Template::Error (undefined method `id' for nil:NilClass):
    11:     <%= f.check_box :private_notes, :no_label => true %>
    12:       <label for="issue_private_notes"><%= l(:field_private_notes) %>  </label>
    13:     <% end %>
    14:     <%= call_hook(:view_journals_notes_form_after_notes, { :issue => @issue}) %>
    15:
    16:     <p><%= render :partial => 'attachments/form', :locals => {:container => @issue} %></p>
    17:     </fieldset>
  plugins/redmine_ckeditor/lib/redmine_ckeditor/hooks/journal_listener.rb:10:in `view_journals_notes_form_after_notes'
  lib/redmine/hook.rb:61:in `block (2 levels) in call_hook'
  lib/redmine/hook.rb:61:in `each'
  lib/redmine/hook.rb:61:in `block in call_hook'
  lib/redmine/hook.rb:58:in `tap'
  lib/redmine/hook.rb:58:in `call_hook'
  lib/redmine/hook.rb:96:in `call_hook'
  app/views/journals/_notes_new_form.html.erb:14:in `block in _app_views_journals__notes_new_form_html_erb__4104637093308884883_47486000'
  app/helpers/application_helper.rb:1030:in `labelled_form_for'
  app/views/journals/_notes_new_form.html.erb:5:in `_app_views_journals__notes_new_form_html_erb__4104637093308884883_47486000'
  app/views/issues/show.html.erb:132:in `_app_views_issues_show_html_erb___4381887501222243197_48895720'
  app/controllers/issues_controller.rb:118:in `block (2 levels) in show'
  app/controllers/issues_controller.rb:115:in `show'
  lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Line 10 in the file plugins/redmine_ckeditor/lib/redmine_ckeditor/hooks/journal_listener.rb:

var note_id = "journal_#{journal.id}_notes";

I don't know a whole lot about Redmine code and plugins, but shouldn't it be passed a journal object in order for it to work, or should the listener on the plugin be changed so that it works if it doesn't receive a journal object?

Hi, I applied the patch, tried it and it has a problem with redmine_ckeditor. Someone solved it?

It can't work properly. When I installed the last patch the Edit button stopped opening the block for editing
Redmine version 3.3.1
Any of thoughts? In console (Devtools) I did not see any errors..

Can anyone help to get it working on redmine 3.4? Really need this.

+1 If we could get this patch integrated it would be an extremely huge step forward.
This is the one of the first questions everybody asks if I show them how to use Redmine.

+1 for this

Hey everyone.

I tried to apply the latest patch, but it fails for some reason I couldn't figured out :

|diff --git a/app/views/issues/_action_menu.html.erb b/app/views/issues/_action_menu.html.erb
|index b535fae..de255bc 100644
|--- a/app/views/issues/_action_menu.html.erb
|+++ b/app/views/issues/_action_menu.html.erb
--------------------------
File to patch:

Can someone point me at the right direction ?
Thanks :)

--
Léo.

Which command did you use to apply the patch? patch -p0? patch -p1? git apply?

Ismael Barros² wrote:

Which command did you use to apply the patch? patch -p0? patch -p1? git apply?

Hey Ismael,

Sorry I didn't check on updates about that.
I used "patch -p0 < 0001b-Adds-Add-notes-link-to-issue-page-to-add-only-notes.patch" inside redmine root's folder.

(saw on https://www.redmine.org/projects/redmine/wiki/patch)

For the record, the detailed error message :

gorby@server:/usr/www/redmine # patch -p0 < 0001b-Adds-Add-notes-link-to-issue-page-to-add-only-notes.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From 472b31017a84d8c91330dccfb47d241c8ae4a2bb Mon Sep 17 00:00:00 2001
|From: Marius <marius.****@zitec.com>
|Date: Tue, 26 Feb 2019 07:33:10 +0000
|Subject: Adds "Add notes" link to issue page to add only notes
|
|Signed-off-by: Jose <jose@***>
|---
| app/views/issues/_action_menu.html.erb      |  3 +++
| app/views/issues/_action_menu_edit.html.erb |  2 +-
| app/views/issues/_edit.html.erb             |  8 ++++----
| config/locales/en.yml                       |  1 +
| public/javascripts/application.js           | 14 ++++++++++++++
| public/stylesheets/application.css          |  2 +-
| 6 files changed, 24 insertions(+), 6 deletions(-)
|
|diff --git a/app/views/issues/_action_menu.html.erb b/app/views/issues/_action_menu.html.erb
|index bd7bcc05f..aabd5c021 100644
|--- a/app/views/issues/_action_menu.html.erb
|+++ b/app/views/issues/_action_menu.html.erb
--------------------------

--
Léo.

Directories a/ and b/ won't actually exist on your filesystem, so I think you need to use patch -p1 instead of patch -p0

Ismael Barros² wrote:

Directories a/ and b/ won't actually exist on your filesystem, so I think you need to use patch -p1 instead of patch -p0

Ismael,

Thanks for the heads up, I didn't know anything about the "patch" command :)
Your suggestion was correct, and with "p1" instead of "p0", everything run smoothly.

Greetings from Paris, France !

--
Léo.