Redmine

Marius BALTEANU wrote:

Nice feature, let me find a better way to pass the auto complete endpoint for each case (issues, wiki pages, etc).

I've posted an alternative solution in #34122, please let me know what do you think about it.

• Use a collection for triggers (see my note from #33425)
• Explore the possibility to show the wiki pages in parent - child relation or at least the parent if any in order to avoid confusion when there are multiple pages with the same title, but under different parent pages.

Marius BALTEANU wrote:

Beside this point, the patch needs at least two changes:

• Use a collection for triggers (see my note from #33425)
• Explore the possibility to show the wiki pages in parent - child relation or at least the parent if any in order to avoid confusion when there are multiple pages with the same title, but under different parent pages.

I think the latter is not a problem. Wiki page names are unique in a project. You cannot create Wiki pages with the same name even if its parent pages are different.

Mizuki, can you add a system tests for this? you should have enough examples.

I found a security issue.

Auto complete for wiki pages should not suggest pages that the current user cannot view. The current patch always shows wiki pages even if the current user does not have "View wiki".