Feature #202
open
Textilization of Documents, News and Timelog-entry comments
0%
Description
I've noticed another missing textilization:
Under projects/list_documents page, documents are listed with
a preview of their descriptions. However, the descriptions are
not textilized. When the description is shown under the documents/show
page, it is correctly textilized.
Files
Related issues
Updated by Warren Harris almost 17 years ago
Here's another one... seems like there's no reason the news
summary shouldn't also be textilized. (patch included)
Updated by Mischa The Evil about 15 years ago
- Category set to Text formatting
Just a bump on the issue. Plus is seems slightly related to issue #3740.
Updated by Mischa The Evil about 15 years ago
- Subject changed from another missing textilization to Textilization of Documents and News
Changed subject only.
Updated by Mischa The Evil about 15 years ago
- Tracker changed from Defect to Feature
Updated by Mischa The Evil about 15 years ago
Warren Harris wrote:
[...] When the description is shown under the documents/show
page, it is correctly textilized [...]
Except that syntax-highlighting isn't working in that specific case: see issue #3740.
Updated by Mischa The Evil about 15 years ago
- File textilize-document-description_r3084.patch textilize-document-description_r3084.patch added
- File textilize-news-summary_r3084.patch textilize-news-summary_r3084.patch added
- File textilize-timelog-entry-comment_r3084.patch textilize-timelog-entry-comment_r3084.patch added
- Subject changed from Textilization of Documents and News to Textilization of Documents, News and Timelog-entry comments
I'll make a summary of several different changes regarding proposals to render content as being "textilized":
1. I'll start with the initial request: At the documents page (at http://host.domain.tld/projects/projectfoo/documents) documents are listed with a preview of their descriptions. However, the descriptions are not textilized.
When the description is shown under the documents/show page (at http://host.domain.tld/documents/1), it is correctly textilized.
(patch; textilize-document-description_r3084.patch)
2. Lateron in the journal of this issue the textilisation of the news summary is also proposed and patched.
(patch; textilize-news-summary_r3084.patch)
3. I've now also merged issue #221 into this issue. It's basically a simple request to render the timelog-entry comments also textilized.
(patch; textilize-timelog-entry-comment_r3084.patch)
I've rebased all three patches against the latest trunk and attached them to this issue. I'll close/update issue #221 as being a (partial) duplicate of this issue (patch #221 does some more then what the issue's description says, which is only textilisation of the timelog-comment).
Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?
Updated by Mischa The Evil about 15 years ago
Mischa The Evil wrote:
[...] several different changes regarding proposals to render content as being "textilized":
1. [...] (patch; textilize-document-description_r3084.patch) [...]
2. [...] (patch; textilize-news-summary_r3084.patch [...]
3. [...] (patch; textilize-timelog-entry-comment_r3084.patch [...]
[...]
Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?
My personal proposal would be to only merge the patch for number 3. That one seems to provide the most useable UI-enhancement with a small change without any unwanted side-effects.
Number 2 seems to has a slight side-effect on the project-overview block and the news index view where trailing new-lines are added. Number 1 seems a good start considering related issue #3740 but therefor also seems to have a higher severity when integrating it in the current state of Redmine (before 0.9 feature freeze).
NB: With all these patches there exists a chance that the users enter comments with markup which /could/ make the UI break. It should be handled with care. This might also be a good reason to decline all off the three patches...
Updated by Jean-Philippe Lang almost 15 years ago
Text formatting on documents index added in r3602.
Updated by Gustavo Gama almost 15 years ago
- File long_and_textilized_time_entry_comments.patch long_and_textilized_time_entry_comments.patch added
I'm attaching a improved (imho) version of Micha's third patch (the one that deals with time entry comments).
It 'textilizes' time entry comments and removes the length restriction. Also, the form text_fields to enter the time entries were replaced by text_areas's.
Updated by Terence Mill over 13 years ago
related with #8668 - missing WIki full textile for project overview
Updated by Ivan Cenov almost 12 years ago
Terence Mill wrote:
related with #8668 - missing WIki full textile for project overview
Not missing on present day.
News are textilized
time entry comment are not textilized
Updated by Mischa The Evil almost 12 years ago
Updated by Dipan Mehta over 11 years ago
+1. This is very useful.
When is this likely to be fully accomplished?
Updated by Anonymous over 8 years ago
+1
Textilization in the above mentioned areas would be helpful.
Updated by Marius BĂLTEANU almost 8 years ago
The attached patch adds textilization to spent time comments also.
Updated by Marius BĂLTEANU almost 8 years ago
Having textilization support for spent time comments is quite useful. Please let me know if tests are required for my patch.
Updated by Dipan Mehta about 7 years ago
The document and news already seems to have textilization support as it seems. Don't know since when though!
Can we also complete the last part as well?
Second oldest unresolved issue by now.
Updated by Takenori TAKAKI over 2 years ago
- File textilization_for_spent_time_comments_with_test.patch textilization_for_spent_time_comments_with_test.patch added
+1 Textlization of the spent time comments would be very useful.
I confirmed that the patch posted by Marius Ionescu in #202#note-15 works with the latest version of trunk (r21619).
I made a patch with a little bit refactoring and additional test code, and attache it.
Updated by Go MAEDA over 1 year ago
- Target version changed from Unplanned backlogs to 5.1.0
Setting the target version to 5.1.
Updated by Go MAEDA about 1 year ago
- File clipboard-202310091009-lju9y.png clipboard-202310091009-lju9y.png added
- Target version changed from 5.1.0 to 6.0.0
Takenori TAKAKI wrote in #note-19:
+1 Textlization of the spent time comments would be very useful.
I confirmed that the patch posted by Marius Ionescu in #202#note-15 works with the latest version of trunk (r21619).
I made a patch with a little bit refactoring and additional test code, and attache it.
Thank you for updating the patch but I think the patch should not render Markdown/Textile also in the Spent time tab of an issue.
Updated by Takenori TAKAKI about 1 year ago
Updated by Marius BĂLTEANU about 2 months ago
- Target version changed from 6.0.0 to Candidate for next major release
Updated by Marius BĂLTEANU about 2 months ago
- Target version changed from Candidate for next major release to 6.1.0