Feature #3088
open
Estimated hours field able to hide role based
0%
Description
adding the option to hide this field to the "roles and permissions" manager
Files
Related issues
Updated by Eric Davis almost 14 years ago
- Status changed from New to 7
- Assignee set to Eric Davis
- Estimated time deleted (
0.50 h)
I've got something like this hacked onto my site right now that I can extract and cleanup a bit.
Updated by
Updated by Anton Nepomnyaschih almost 12 years ago
+1 It would be very good to get this, as we have to hide our estimations from some roles :(
Updated by 
Updated by 
Updated by
Updated by Dominique Lederer about 11 years ago
made a plugin for this: http://www.redmine.org/plugins/redmine_hide_estimated_hours
Updated by Pavel Bahushevich over 10 years ago
does anybody have version 1.0.0 of this plugin?
Updated by Jean-Philippe Lang about 10 years ago
- Status changed from 7 to New
Assigned issue with no assignee back to New status.
Updated by Go MAEDA about 4 years ago
- Has duplicate Feature #3781: Add permission to control viewing of Estimated Hours based on Role added
Updated by Go MAEDA about 4 years ago
- Has duplicate Feature #15107: Add a permission option to view estimated hours added
Updated by Marius BALTEANU about 4 years ago
- Related to Feature #12005: Mightful workflow field enhancement: hide added
Updated by Go MAEDA about 4 years ago
- Has duplicate Feature #11963: Hide the estimated times on issues for certain roles added
Updated by Bernhard Rohloff about 4 years ago
+1 It would be great to have estimated times integrated in the allover times permissions system.
Updated by
Updated by Yuichi HARADA almost 4 years ago
- File add_permission_view_estimated_hours.png add_permission_view_estimated_hours.png added
- File 3088.patch 3088.patch added
Add "View estimated hours" permission to the "Roles and permissions".
If the project has the "Time tracking" module enabled and the role has "View estimated time" permission enabled, the "Estimated hours" field is available.
I attached a patch.
Updated by Go MAEDA over 3 years ago
- Target version set to Candidate for next major release
Updated by Yuichi HARADA about 3 years ago
- File 3088-v2.patch 3088-v2.patch added
Go MAEDA wrote:
Now the patch cannot be applied cleanly.
Fixed the patch to work on the current trunk(r19478).
Updated by Go MAEDA almost 3 years ago
Yuichi HARADA wrote:
Fixed the patch to work on the current trunk(r19478).
Thank you for the patch. But I am hesitant to make this patch a candidate for 4.2.0. This is because existing users who can currently see estimated hours will lose access to it after applying the patch because view_estimated_hours will not be granted to no roles by default.
Updated by Go MAEDA about 1 year ago
Go MAEDA wrote:
Yuichi HARADA wrote:
Fixed the patch to work on the current trunk(r19478).
Thank you for the patch. But I am hesitant to make this patch a candidate for 4.2.0. This is because existing users who can currently see estimated hours will lose access to it after applying the patch because view_estimated_hours will not be granted to no roles by default.
Adding a migration like the following will resolve the above problem.
diff --git a/db/migrate/20220315101502_add_view_estimated_hours_to_all_existing_roles.rb b/db/migrate/20220315101502_add_view_estimated_hours_to_all_existing_roles.rb
new file mode 100644
index 000000000..ed2ad47de
--- /dev/null
+++ b/db/migrate/20220315101502_add_view_estimated_hours_to_all_existing_roles.rb
@@ -0,0 +1,9 @@
+class AddViewEstimatedHoursToAllExistingRoles < ActiveRecord::Migration[6.1]
+ def up
+ Role.all.each { |role| role.add_permission! :view_estimated_hours }
+ end
+
+ def down
+ # nothing to revert
+ end
+end
Updated by Victor C 8 months ago
- File 3088-v2_5.0.2.patch 3088-v2_5.0.2.patch added
Updated by Go MAEDA 8 months ago
- File 3088-v3.diff 3088-v3.diff added
The patch still needs to be added some code. Even after revoking the privilege from a user, the update history of the estimated hours field is exposed via issue journal.
Updated by Yuichi HARADA 8 months ago
- File 3088-v4.patch 3088-v4.patch added
Go MAEDA wrote:
The patch still needs to be added some code. Even after revoking the privilege from a user, the update history of the estimated hours field is exposed via issue journal.
It will be improved in the following patch.
diff --git a/app/models/journal.rb b/app/models/journal.rb
index 919a07dd2e..16a9699be4 100644
--- a/app/models/journal.rb
+++ b/app/models/journal.rb
@@ -111,6 +111,8 @@ class Journal < ActiveRecord::Base
detail.custom_field && detail.custom_field.visible_by?(project, user)
elsif detail.property == 'relation'
Issue.find_by_id(detail.value || detail.old_value).try(:visible?, user)
+ elsif detail.property == 'attr' && detail.prop_key == 'estimated_hours'
+ user.allowed_to?(:view_estimated_hours, project)
else
true
end
Updated by