Redmine

Looks good to me.

A similar patch #16133 was rejected 5 years ago due to performance concerns when a project has a lot of members, but I think 0002-Do-not-propose-watchers-that-are-not-allowed-to-see-.patch does not introduce the performance problem because watchable_object.visible? is only called 200 times, only when the user open Add watchers dialog.

Hello, everyone,

thanks for your work.

Related to these changes, I believe, having ability to add us user as a watcher and to get a message later on he/she can see the issue is little bit weird...

Also adding rights to the watcher for the issue means currently (if I'm not mistaken) to add him ability to see all the issues within whole project, which is not wanted in most cases. When someone can't see all the issues it's usually ofr some reason. And when adding as a watcher of one shouldn't require permission for all.

I believe we need something like this (soft read only permission for watched issues):

https://github.com/maxrossello/redmine_extended_watchers

Thank you so much
Kind regards
Jan

Jenda Benda wrote in #note-11:

Related to these changes, I believe, having ability to add us user as a watcher and to get a message later on he/she can see the issue is little bit weird...

In an unchanged Redmine, you can only add a watcher to an issue if the user can already see the issue. It is however possible that later on, the user loses the right to see the issue. In that case, they still remain a watcher but will not receive any notifications for the issue nor will they be able to see it. For other users, the watcher will then be rendered with the "invalid watcher" message.

Also adding rights to the watcher for the issue means currently (if I'm not mistaken) to add him ability to see all the issues within whole project, which is not wanted in most cases.

That is not correct. In a default Redmine, adding a watcher does not add any additional permissions and thus does not allow the watcher to see an issue they can not see otherwise. There is however a feature request to update the watchers functionality to grant watchers read-only permissions to issues they watch, see #8488.

Here (and in all plugins and related implementations I'm aware, including on Planio), adding a watcher to an issue will only grant the watcher additional read access to this single issue, not to all issues in the project.

When someone can't see all the issues it's usually ofr some reason. And when adding as a watcher of one shouldn't require permission for all.

Yes, that is the behavior of Redmine.

I believe we need something like this (soft read only permission for watched issues):

https://github.com/maxrossello/redmine_extended_watchers

This plugin implements a similar functionality to what is described in #8488, #7412, #23546 and several other similar issues. Initially this change was rejected by Jean-Philippe Lang. See #7412#note-13

Hello, thanks for the reply and all the information.

I'm not sure why, but in our redmine instance we can add "watchers" role to the users that can't see the issue, but are members of the same project. The instalation is 2 week fresh, where we have just "additionals" plugin installed. This is probably the only thing that might change the default behavior, but I doubt it is the case... Any idea how's that possible then?
That's the reason why we are getting into the weird situation, where anyone can assign as a watcher anyone from the same project(customer), but then gets the warning message about the user not being able to see the issue.

That is not correct. In a default Redmine, adding a watcher does not add any additional permissions and thus does not allow the watcher to see an issue they can not see otherwise. There is however a feature request to update the watchers functionality to grant watchers read-only permissions to issues they watch, see #8488.

I'm sorry for bad explanation/wording... I meant that currently if we would like to enable watchers to be added to the certain issues in their project....we have to allow them to see all the issues of the project manually first.
Is there any other way how to assign an issue to the users of the same project who can't see all the issues within the project?
The thing is we were used to (e.g. in Jira) to do that. But at the same time we do not want users to see all issues by default (just in case anyone would like to assign them as watchers)...

thank you so much
Kind regards
Jan

Please move this discussion over to the forums. This unrelated and closed issue is not the right place for this.