Feature #16098: On relation change/add notification setting - Redmine

Actions

Copy link

Feature #16098

open

On relation change/add notification setting

Added by Markus Nemetz almost 11 years ago. Updated over 1 year ago.

Status:

New

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Email notifications

Target version:

Candidate for next major release

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Description

Would it be possible to enable a following feature?

On Relation add/Change no status mail should be sent (to be set yes/no)

Reason: It leads to spam

Files

Download all files

notified_events_relation@2x.png (22 KB) notified_events_relation@2x.png		Go MAEDA, 2019-09-19 02:21
16098_notified_events_relation.patch (3.91 KB) 16098_notified_events_relation.patch		Yuichi HARADA, 2019-09-25 09:11
email-deliveries@2x.png (29.7 KB) email-deliveries@2x.png		Go MAEDA, 2019-10-02 05:20
16098_notified_events_relation-v2.patch (3.93 KB) 16098_notified_events_relation-v2.patch		Yuichi HARADA, 2019-10-03 03:45
16098_notified_events_relation-v3.patch (3.84 KB) 16098_notified_events_relation-v3.patch		Yuichi HARADA, 2019-10-07 02:58
16098_notified_events_relation-v4.patch (3.85 KB) 16098_notified_events_relation-v4.patch		Go MAEDA, 2019-12-20 05:55

Related issues

Actions

Copy link

Updated by Toshi MARUYAMA over 10 years ago

Subject changed from On relation change/add do not send mail to On relation change/add notification setting

Actions

Copy link

Updated by Robert Pollak over 10 years ago

Duplicated by #17208.

Actions

Copy link

Updated by Etienne Massip over 10 years ago

Has duplicate Feature #17208: Make relation change notifications configurable added

Actions

Copy link

Updated by Zbynek Drlik about 10 years ago

Actions

Copy link

Updated by Marcel Gavalier about 10 years ago

Actions

Copy link

Updated by @ go2null about 10 years ago

A mitigation would be to allow adding multiple relations before submitting.
Of course, adding this to the regular issue Edit would be awesome.
(There's already a request for this - Feature #5238 Related issues option accessible during issue creation)

Actions

Copy link

Updated by Toshi MARUYAMA almost 10 years ago

Related to Feature #5238: Related issues option accessible during issue creation added

Actions

Copy link

Updated by Go MAEDA over 9 years ago

Related to Feature #10792: Adding/deleting a sub-issue or some issue-relation should trigger an email added

Actions

Copy link

Updated by Kevin Palm over 9 years ago

Actions

Copy link

#10

Updated by Marc D. over 9 years ago

Actions

Copy link

#11

Updated by Patryk Bar about 9 years ago

Actions

Copy link

#12

Updated by Moh Ahmed about 8 years ago

Actions

Copy link

#13

Updated by Marc D. over 7 years ago

+1
Maybe just add it to the Setting -> Email notifications menu

Actions

Copy link

#14

Updated by Jonas De Meulenaere about 7 years ago

Actions

Copy link

#15

Updated by Christophe Portier about 6 years ago

Many users in my company complain about this
=> + at least 10

Actions

Copy link

#16

Updated by Tomohisa Kusukawa over 5 years ago

Actions

Copy link

#17

Updated by Yuuki NARA over 5 years ago

Actions

Copy link

#18

Updated by Go MAEDA over 5 years ago

File notified_events_relation@2x.png notified_events_relation@2x.png added

I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.

Actions

Copy link

#19

Updated by Yuuki NARA over 5 years ago

Just change the one line below and email will not be sent when setting the relation.

This is just a workaround.
Of course, it is best to select a check box for email notification. #note-18

I confirmed the operation with Redmine3.4.
The same goes for 4.0.

I hope it helps

models/journal.rb
def send_notification

(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
)
Mailer.deliver_issue_edit(self)

(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
) && !(new_value_for('relates').present?)
Mailer.deliver_issue_edit(self)

Actions

Copy link

#20

Updated by Yuichi HARADA about 5 years ago

File 16098_notified_events_relation.patch 16098_notified_events_relation.patch added

Go MAEDA wrote:

I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.

Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.

Actions

Copy link

#21

Updated by Go MAEDA about 5 years ago

Target version set to Candidate for next major release

Actions

Copy link

#22

Updated by Go MAEDA about 5 years ago

Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

Actions

Copy link

#23

Updated by Go MAEDA about 5 years ago

Status changed from New to Needs feedback
Target version changed from 4.2.0 to Candidate for next major release

Yuichi HARADA wrote:

Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.

A test fails on r18582. Could you check the patch?

$ bin/rails test test/unit/journal_observer_test.rb:178
Run options: --seed 52037

# Running:

F

Failure:
JournalObserverTest#test_create_relation_should_send_email_notification_with_issue_relation_updated [/Users/maeda/redmines/trunk/test/unit/journal_observer_test.rb:190]:
Expected: 2
  Actual: 4

bin/rails test test/unit/journal_observer_test.rb:178

Finished in 3.732650s, 0.2679 runs/s, 0.5358 assertions/s.
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips

Actions

Copy link

#24

Updated by Go MAEDA about 5 years ago

File email-deliveries@2x.png email-deliveries@2x.png added

Go MAEDA wrote:

A test fails on r18582. Could you check the patch?

I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).

Actions

Copy link

#25

Updated by Yuichi HARADA about 5 years ago

File 16098_notified_events_relation-v2.patch 16098_notified_events_relation-v2.patch added

Go MAEDA wrote:

Go MAEDA wrote:

A test fails on r18582. Could you check the patch?

I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).

Thank you for pointing it out. The reason for the incorrect assertion result was not enough fixtures.
I rewrote the patch.

Actions

Copy link

#26

Updated by Go MAEDA about 5 years ago

Status changed from Needs feedback to New

Actions

Copy link

#27

Updated by Mischa The Evil about 5 years ago

Yuichi HARADA wrote:

[...]
I rewrote the patch.

Can you split the test like you did with the patch for #17840?

Actions

Copy link

#28

Updated by Yuichi HARADA about 5 years ago

File 16098_notified_events_relation-v3.patch 16098_notified_events_relation-v3.patch added

Mischa The Evil wrote:

Yuichi HARADA wrote:

[...]
I rewrote the patch.

Can you split the test like you did with the patch for #17840?

Thank you for pointing it out. I split the test.
Attach the patch.

Actions

Copy link

#29

Updated by Go MAEDA about 5 years ago

File 16098_notified_events_relation-v4.patch 16098_notified_events_relation-v4.patch added
Target version changed from Candidate for next major release to 4.1.0

Setting the target version to 4.1.0. I think it is better to deliver this feature along with #17840 in 4.1.0.

Attached is an updated patch that can be applied to the current trunk.

Actions

Copy link

#30

Updated by Jean-Philippe Lang about 5 years ago

Target version changed from 4.1.0 to 4.2.0

I think that this patch doesn't solve the reported issue.
What it brings : it would let users enable notification for relations when they haven't enabled notification for all updates.
What is requested : have notifications for all updates except when relations are updated

The right solution would be to add checkboxes for all the possible causes of notification and let users choose.

Actions

Copy link

#31