Feature #16098

On relation change/add notification setting

Added by Markus Nemetz about 6 years ago. Updated 2 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email notifications
Target version:4.2.0
Resolution:

Description

Would it be possible to enable a following feature?

  • On Relation add/Change no status mail should be sent (to be set yes/no)

Reason: It leads to spam

notified_events_relation@2x.png (22 KB) Go MAEDA, 2019-09-19 02:21

16098_notified_events_relation.patch Magnifier (3.91 KB) Yuichi HARADA, 2019-09-25 09:11

email-deliveries@2x.png (29.7 KB) Go MAEDA, 2019-10-02 05:20

16098_notified_events_relation-v2.patch Magnifier (3.93 KB) Yuichi HARADA, 2019-10-03 03:45

16098_notified_events_relation-v3.patch Magnifier (3.84 KB) Yuichi HARADA, 2019-10-07 02:58

16098_notified_events_relation-v4.patch Magnifier (3.85 KB) Go MAEDA, 2019-12-20 05:55


Related issues

Related to Redmine - Feature #5238: Related issues option accessible during issue creation New 2010-04-02
Related to Redmine - Feature #10792: Adding/deleting a sub-issue or some issue-relation should... New
Duplicated by Redmine - Feature #17208: Make relation change notifications configurable Closed

History

#1 Updated by Toshi MARUYAMA almost 6 years ago

  • Subject changed from On relation change/add do not send mail to On relation change/add notification setting

#2 Updated by Robert Pollak over 5 years ago

Duplicated by #17208.

#3 Updated by Etienne Massip over 5 years ago

  • Duplicated by Feature #17208: Make relation change notifications configurable added

#4 Updated by Zbynek Drlik over 5 years ago

+1

#5 Updated by Marcel Gavalier over 5 years ago

+1

#6 Updated by @ go2null over 5 years ago

A mitigation would be to allow adding multiple relations before submitting.
Of course, adding this to the regular issue Edit would be awesome.
(There's already a request for this - Feature #5238 Related issues option accessible during issue creation)

#7 Updated by Toshi MARUYAMA about 5 years ago

  • Related to Feature #5238: Related issues option accessible during issue creation added

#8 Updated by Go MAEDA almost 5 years ago

  • Related to Feature #10792: Adding/deleting a sub-issue or some issue-relation should trigger an email added

#9 Updated by Kevin Palm over 4 years ago

+1

#10 Updated by Marc M. over 4 years ago

+1

#11 Updated by Patryk Bar about 4 years ago

+1

#12 Updated by Moh Ahmed over 3 years ago

+1

#13 Updated by Marc M. over 2 years ago

+1
Maybe just add it to the Setting -> Email notifications menu

#15 Updated by Christophe Portier over 1 year ago

Many users in my company complain about this
=> + at least 10

#16 Updated by Tomohisa Kusukawa 5 months ago

+1

#17 Updated by Yuuki NARA 5 months ago

+1

#18 Updated by Go MAEDA 5 months ago

I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.

#19 Updated by Yuuki NARA 5 months ago

Just change the one line below and email will not be sent when setting the relation.

This is just a workaround.
Of course, it is best to select a check box for email notification. #note-18

I confirmed the operation with Redmine3.4.
The same goes for 4.0.

I hope it helps

models/journal.rb
def send_notification

(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
)
Mailer.deliver_issue_edit(self)

to

(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
) && !(new_value_for('relates').present?)
Mailer.deliver_issue_edit(self)

#20 Updated by Yuichi HARADA 5 months ago

Go MAEDA wrote:

I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.

Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.

#21 Updated by Go MAEDA 5 months ago

  • Target version set to Candidate for next major release

#22 Updated by Go MAEDA 5 months ago

  • Target version changed from Candidate for next major release to 4.2.0

Setting the target version to 4.2.0.

#23 Updated by Go MAEDA 5 months ago

  • Status changed from New to Needs feedback
  • Target version changed from 4.2.0 to Candidate for next major release

Yuichi HARADA wrote:

Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.

A test fails on r18582. Could you check the patch?

$ bin/rails test test/unit/journal_observer_test.rb:178
Run options: --seed 52037

# Running:

F

Failure:
JournalObserverTest#test_create_relation_should_send_email_notification_with_issue_relation_updated [/Users/maeda/redmines/trunk/test/unit/journal_observer_test.rb:190]:
Expected: 2
  Actual: 4

bin/rails test test/unit/journal_observer_test.rb:178

Finished in 3.732650s, 0.2679 runs/s, 0.5358 assertions/s.
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips

#24 Updated by Go MAEDA 5 months ago

Go MAEDA wrote:

A test fails on r18582. Could you check the patch?

I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).

#25 Updated by Yuichi HARADA 5 months ago

Go MAEDA wrote:

Go MAEDA wrote:

A test fails on r18582. Could you check the patch?

I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).

Thank you for pointing it out. The reason for the incorrect assertion result was not enough fixtures.
I rewrote the patch.

#26 Updated by Go MAEDA 5 months ago

  • Status changed from Needs feedback to New

#27 Updated by Mischa The Evil 5 months ago

Yuichi HARADA wrote:

[...]
I rewrote the patch.

Can you split the test like you did with the patch for #17840?

#28 Updated by Yuichi HARADA 5 months ago

Mischa The Evil wrote:

Yuichi HARADA wrote:

[...]
I rewrote the patch.

Can you split the test like you did with the patch for #17840?

Thank you for pointing it out. I split the test.
Attach the patch.

#29 Updated by Go MAEDA 2 months ago

Setting the target version to 4.1.0. I think it is better to deliver this feature along with #17840 in 4.1.0.

Attached is an updated patch that can be applied to the current trunk.

#30 Updated by Jean-Philippe Lang 2 months ago

  • Target version changed from 4.1.0 to 4.2.0

I think that this patch doesn't solve the reported issue.
What it brings : it would let users enable notification for relations when they haven't enabled notification for all updates.
What is requested : have notifications for all updates except when relations are updated

The right solution would be to add checkboxes for all the possible causes of notification and let users choose.

#31 Updated by Jean-Philippe Lang 2 months ago

  • Assignee set to Jean-Philippe Lang

Also available in: Atom PDF