Feature #16098
open
On relation change/add notification setting
Added by Markus Nemetz about 11 years ago.
Updated over 1 year ago.
Category:
Email notifications
Description
Would it be possible to enable a following feature?
- On Relation add/Change no status mail should be sent (to be set yes/no)
Reason: It leads to spam
Files
- Subject changed from On relation change/add do not send mail to On relation change/add notification setting
- Has duplicate Feature #17208: Make relation change notifications configurable added
A mitigation would be to allow adding multiple relations before submitting.
Of course, adding this to the regular issue Edit would be awesome.
(There's already a request for this - Feature #5238 Related issues option accessible during issue creation)
- Related to Feature #5238: Related issues option accessible during issue creation added
- Related to Feature #10792: Adding/deleting a sub-issue or some issue-relation should trigger an email added
+1
Maybe just add it to the Setting -> Email notifications menu
Many users in my company complain about this
=> + at least 10
I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.
Just change the one line below and email will not be sent when setting the relation.
This is just a workaround.
Of course, it is best to select a check box for email notification. #note-18
I confirmed the operation with Redmine3.4.
The same goes for 4.0.
I hope it helps
models/journal.rb
def send_notification
(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
)
Mailer.deliver_issue_edit(self)
to
(Setting.notified_events.include?('issue_priority_updated') && new_value_for('priority_id').present?)
) && !(new_value_for('relates').present?)
Mailer.deliver_issue_edit(self)
Go MAEDA wrote:
I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.
Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.
- Target version set to Candidate for next major release
- Target version changed from Candidate for next major release to 4.2.0
Setting the target version to 4.2.0.
- Status changed from New to Needs feedback
- Target version changed from 4.2.0 to Candidate for next major release
Yuichi HARADA wrote:
Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
I attached a patch.
A test fails on r18582. Could you check the patch?
$ bin/rails test test/unit/journal_observer_test.rb:178
Run options: --seed 52037
# Running:
F
Failure:
JournalObserverTest#test_create_relation_should_send_email_notification_with_issue_relation_updated [/Users/maeda/redmines/trunk/test/unit/journal_observer_test.rb:190]:
Expected: 2
Actual: 4
bin/rails test test/unit/journal_observer_test.rb:178
Finished in 3.732650s, 0.2679 runs/s, 0.5358 assertions/s.
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
Go MAEDA wrote:
A test fails on r18582. Could you check the patch?
I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).
Go MAEDA wrote:
Go MAEDA wrote:
A test fails on r18582. Could you check the patch?
I think the expected value of ActionMailer::Base.deliveries.size should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (jsmith and dlopper). jsmith is the author of both issues. dlopper receives all notification of the project (his email notifications setting is "For any event on all my projects).
Thank you for pointing it out. The reason for the incorrect assertion result was not enough fixtures.
I rewrote the patch.
- Status changed from Needs feedback to New
Yuichi HARADA wrote:
[...]
I rewrote the patch.
Can you split the test like you did with the patch for #17840?
Mischa The Evil wrote:
Yuichi HARADA wrote:
[...]
I rewrote the patch.
Can you split the test like you did with the patch for #17840?
Thank you for pointing it out. I split the test.
Attach the patch.
Setting the target version to 4.1.0. I think it is better to deliver this feature along with #17840 in 4.1.0.
Attached is an updated patch that can be applied to the current trunk.
- Target version changed from 4.1.0 to 4.2.0
I think that this patch doesn't solve the reported issue.
What it brings : it would let users enable notification for relations when they haven't enabled notification for all updates.
What is requested : have notifications for all updates except when relations are updated
The right solution would be to add checkboxes for all the possible causes of notification and let users choose.
- Assignee set to Jean-Philippe Lang
- Target version changed from 4.2.0 to 5.0.0
- Target version changed from 5.0.0 to Candidate for next major release
- Related to Patch #36265: More flexible options for issue notifications added
Also available in: Atom
PDF
Updated by Toshi MARUYAMA almost 11 years ago
Updated by 
Updated by Etienne Massip almost 11 years ago
Updated by 
Updated by 
Updated by 
Updated by Go MAEDA almost 10 years ago
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by 
Updated by Yuichi HARADA over 5 years ago
Updated by 
Updated by 
Updated by Marius BĂLTEANU about 3 years ago
Updated by 
Updated by 
Updated by 
Updated by Jonas De Meulenaere 7 months ago