Defect #5593
closed
Grey out workflow checkboxes for transitions to the same status
Added by Yuki Kita over 14 years ago. Updated over 6 years ago.
0%
Description
In workflow settings, it is configurable whether the current status can transit to the same status or not, though it is self-evident that the current status can transit to the same status.
Files
| edit.rhtml.diff (781 Bytes) edit.rhtml.diff | Yuki Kita, 2010-05-25 17:06 | ||
| Screenshot.png (31.8 KB) Screenshot.png | Yuki Kita, 2010-05-25 17:06 | ||
| 5593-r13306.diff (662 Bytes) 5593-r13306.diff | compatible with Redmine 2.5.2.devel.13306 | Go MAEDA, 2014-07-13 07:38 | |
| 5593-r17212.diff (766 Bytes) 5593-r17212.diff | Patch for Redmine 3.4.4.devel.17212 | Go MAEDA, 2018-02-25 08:04 | |
| 5593-before@2x.png (35.3 KB) 5593-before@2x.png | screenshot (before) | Go MAEDA, 2018-02-25 08:10 | |
| 5593-after@2x.png (34.4 KB) 5593-after@2x.png | screenshot (after) | Go MAEDA, 2018-02-25 08:10 | |
| tests_for_5593.patch (1.21 KB) tests_for_5593.patch | Marius BĂLTEANU, 2018-02-25 16:37 | ||
| 5593-note14@2x.png (35.4 KB) 5593-note14@2x.png | Go MAEDA, 2018-02-26 01:25 | ||
| 5593-r17235.patch (2.01 KB) 5593-r17235.patch | Mizuki ISHIKAWA, 2018-03-14 06:11 | ||
| 5593-r17235-2.patch (3.86 KB) 5593-r17235-2.patch | Mizuki ISHIKAWA, 2018-03-14 06:58 | ||
| wrong-color@2x.png (53.7 KB) wrong-color@2x.png | Checked statuses is displayed in white under the certain conditions | Go MAEDA, 2018-03-19 14:14 | |
| 5593-r17236.patch (4.46 KB) 5593-r17236.patch | Mizuki ISHIKAWA, 2018-03-22 01:17 |
Related issues
Updated by Norbert Bérci over 14 years ago
+1
Is it possible to apply Yuki Kita's patch? It seems extremely simple, but improves greately the UI (removes confusion about why are there same issue transitions).
Updated by Thomas Pihl over 14 years ago
It does look nice. But...
Sometimes we only allow users to create new issues, not change any state. Then we would check the new/new checkbox. How would we solve that?
Updated by Yuki Kita over 14 years ago
Thomas Pihl wrote:
It does look nice. But...
Sometimes we only allow users to create new issues, not change any state. Then we would check the new/new checkbox. How would we solve that?
You do not have to check the new/new checkbox to prohibit users from changing state.
Instead of doing it, uncheck all checkbox and set the default value of issue statuses to "new".
I think this solves your concern.
Updated by 
Updated by
Updated by Norbert Bérci over 14 years ago
To those interested: let's discuss #5816 (about the initial statuses).
Updated by Terence Mill almost 13 years ago
+1
Small but easy embeddable enhancement!
Updated by Go MAEDA over 10 years ago
- File 5593-r13306.diff 5593-r13306.diff added
+1
I have made Yuki Kita's patch compatible with current trunk(Redmine 2.5.2.devel.13306).
Updated by Mischa The Evil over 9 years ago
- Target version set to Candidate for next major release
Updated by Go MAEDA almost 8 years ago
- Related to Patch #16364: Issue workflow doesn't force status transition though workflow is defined so added
Updated by Go MAEDA almost 7 years ago
- File 5593-r17212.diff 5593-r17212.diff added
- File 5593-before@2x.png 5593-before@2x.png added
- File 5593-after@2x.png 5593-after@2x.png added
Updated the patch for the current trunk.
Before:
After:
Updated by Bernhard Rohloff almost 7 years ago
+1
This patch also provides great reference points within the checkbox matrix.
Updated by Marius BĂLTEANU almost 7 years ago
- File tests_for_5593.patch tests_for_5593.patch added
+1
Attached is a patch that fixes an existing failing test and adds a test for Go Maeda's patch.
Updated by Marius BĂLTEANU almost 7 years ago
Reading the tickets and comments from the related issue (#16364) where some users request the "force status transition" feature, I'm wondering if is better to show a disabled checked checkbox instead of "-" in order to make more obvious for the users that the "transition" between the same status is allowed and it cannot be disabled.
Updated by Go MAEDA almost 7 years ago
- File 5593-note14@2x.png 5593-note14@2x.png added
Marius BALTEANU wrote:
I'm wondering if is better to show a disabled checked checkbox instead of "-" in order to make more obvious for the users that the "transition" between the same status is allowed and it cannot be disabled.
That makes sense. Do you mean like this?
Updated by Bernhard Rohloff almost 7 years ago
Marius' suggestion is a neat additional improvement. It coherently presents the current implementation but lets room for future changes without changing parts of the UI.
So if #16364 gets a thing someday, all we have to do is activating the checkboxes again.
Updated by Marius BĂLTEANU almost 7 years ago
Go MAEDA wrote:
That makes sense. Do you mean like this?
Exactly.
Updated by Mischa The Evil almost 7 years ago
- Subject changed from Meanless settings for workflow to Meaningless settings for workflow
- Target version changed from Candidate for next major release to 4.0.0
Updated by Mizuki ISHIKAWA almost 7 years ago
- File 5593-r17235.patch 5593-r17235.patch added
I think Marius' suggestion is good as well.
I updated the patch to add disabled checkbox instead of "-".
Updated by Mizuki ISHIKAWA almost 7 years ago
- File 5593-r17235-2.patch 5593-r17235-2.patch added
Fixed disabled checkbox not to be affected by toggleCheckboxesBySelector.
Updated by Go MAEDA almost 7 years ago
- File wrong-color@2x.png wrong-color@2x.png added
Mizuki, thank you for posting the patch.
But I found that transitions whose source status and destination status are the same are displayed in a different color under certain conditions. Could you look into this and update the patch?
Steps to reproduce:
- Before applying the patch, edit the workflow for "Manager" - "Bug", check all transitions and save. Every transition is displayed in green.
- Uncheck the checkbox for "New" -> "New" transition and save. "New" -> "New" transition should be displayed in white.
- Apply the patch 5593-r17235-2.patch
- Check "Manager" - "Bug" workflow. Transitions like "New" -> "New" and "Assigned -> Assigned" are checked and disabled. Although checked statuses should displayed in green but "New" -> "New" status (unchecked in step 2) is displayed in white.
Updated by Mizuki ISHIKAWA almost 7 years ago
- File 5593-r17236.patch 5593-r17236.patch added
I attached a patch that corrected the problem pointed out to Go MAEDA.
I mainly added the following changes.
diff --git a/app/views/workflows/_form.html.erb b/app/views/workflows/_form.html.erb
index 3fc69c4f5..542db4e35 100644
--- a/app/views/workflows/_form.html.erb
+++ b/app/views/workflows/_form.html.erb
@@ -38,7 +38,7 @@
<% end %>
</td>
<% for new_status in @statuses -%>
- <% checked = workflows.detect {|w| w.old_status == old_status && w.new_status == new_status} %>
+ <% checked = (old_status == new_status) || workflows.detect {|w| w.old_status == old_status && w.new_status == new_status} %>
<td class="<%= checked ? 'enabled' : '' %>" title="<%= old_status_name %> » <%= new_status.name %>">
<%= transition_tag workflows, old_status, new_status, name %>
</td>
But there is one problem with this patch.
The state of workflow is saved as WorkflowTransition. (Even when the source status and the destination status are the same)
When a patch is applied, the checkbox displayed will be checked, even if the data indicates that it is not checked the checkbox.
That is, the data and the displayed results are contradictory.
I think it is difficult to display a disabled checkbox while maintaining consistency with the data.
Updated by Marius BĂLTEANU almost 7 years ago
Mizuki ISHIKAWA wrote:
When a patch is applied, the checkbox displayed will be checked, even if the data indicates that it is not checked the checkbox.
That is, the data and the displayed results are contradictory.
You're worried that the displayed results are not according with the data from the database? For ex: In the UI, the checkbox for New -> New is checked and disabled, but in the db there is no entry in the WorkflowTransition for the transition (I'm asking just to confirm that I understand correctly).
If yes, I don't see a real problem from the following reasons:
- is not a real inconsistency because you don't really need a transition to update a ticket without changing the status.
- only a few users can observe this inconsistency and they need to be quite technical to deep in Redmine code and database.
Updated by Mizuki ISHIKAWA over 6 years ago
Marius BALTEANU wrote:
Mizuki ISHIKAWA wrote:
When a patch is applied, the checkbox displayed will be checked, even if the data indicates that it is not checked the checkbox.
That is, the data and the displayed results are contradictory.You're worried that the displayed results are not according with the data from the database? For ex: In the UI, the checkbox for New -> New is checked and disabled, but in the db there is no entry in the WorkflowTransition for the transition (I'm asking just to confirm that I understand correctly).
Yes, I was worried about it.
If yes, I don't see a real problem from the following reasons:
- is not a real inconsistency because you don't really need a transition to update a ticket without changing the status.
- only a few users can observe this inconsistency and they need to be quite technical to deep in Redmine code and database.
Certainly, I think that few people feel strange about this problem.
I seemed to be over-thinking about it problem.
Thank you for checking, Marius BALTEANU.
Updated by Jean-Philippe Lang over 6 years ago
- Subject changed from Meaningless settings for workflow to Grey out workflow checkboxes for transitions to the same status
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Committed, thanks.