Redmine

I've tried to implement this at https://github.com/Jbekker/redmine_mention_plugin/tree/autocomplete
I changed the syntax to :user instead of user user because that doesn't get triggered when typing a email-address :-( I'm sure there is a way to filter a email adress out but im not a Ruby/JavaScript pro yet.
Currently im not checking if jquery is loaded and there are a few other things that could be done better I suppose. Patches and pull requests are welcome!

+1 for this feature. Mentioned user should not get added to the watcher's list though. Only a one time email should be triggered saying that 'You were mentioned....' or something. Also, there should be email notification setting, where you can appropriately adjust that you want to receive mention email notifications only, etc.

FYI, mentions with email notifications are implemented in WikiNG 1.0.0b.

+1 for this one. Would be really nice to have.

+1
I also tried this one: http://www.redmine.org/plugins/redmine-mentions

The plugin that Alex Sherman posted is cool but doesn't work on comments. +1 to get this implemented.

Arkhitech - More, Better, Faster! wrote:

+1 for this feature. Mentioned user should not get added to the watcher's list though. Only a one time email should be triggered saying that 'You were mentioned....' or something. Also, there should be email notification setting, where you can appropriately adjust that you want to receive mention email notifications only, etc.

I agree. +1

+1 to single email. Plugins for this feature have always been unreliable and trying to communicate on redmine without setting people as watchers is awkward and inefficient.

Lai Wei-Hwa wrote:

The plugin that Alex Sherman posted is cool but doesn't work on comments. +1 to get this implemented.

Alex Sherman wrote:

+1
I also tried this one: http://www.redmine.org/plugins/redmine-mentions

I used the same plugin by Arkhitech, it looks to work as expected for comments, however, does not notify user when mentioned in description of the task. To make autocomplete feature to work with redmine 2.5.2 I used a patch (see pull requtest on GitHub https://github.com/arkhitech/redmine_mentions/pull/34 )

Arkhitech - More, Better, Faster! wrote:

+1 for this feature. Mentioned user should not get added to the watcher's list though. Only a one time email should be triggered saying that 'You were mentioned....' or something. Also, there should be email notification setting, where you can appropriately adjust that you want to receive mention email notifications only, etc.

I agree! +1

+ 1

+1

Yes, please add this feature!

+1

+1

I agree! +1

+1 Keep the dream alive!

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Mention should actually trigger email notification (add user as watcher if it's not added)

We've been looking at this feature, and we're hoping to move from to it from the redmine_mention_plugin plugin¹. The issue we're having with the current plugin is that it doesn't support our usernames that are emails. Are there any plans to support that in this feature? Or if we plan to use this feature should we move away from emails as usernames?

In the existing plugin when we write @, an autocomplete box opens, when we choose a user that is not an email, it converts it to a link to the user correctly, whereas when using an email it does not. We tried modifying the regex but I guess there's more to it than that.

¹ https://github.com/stpl/redmine_mention_plugin

Marius BALTEANU wrote:

I would like to test the solution proposed because looking over the patch proposed, I think that it cannot be committed as it is and it'll require more work.

Could you point out what needs to be corrected? Maybe Mizuki can work on correcting the patch.

Thanks Mizuki for writing the patch.

My main concern regarding the proposed solution is that there is no way for the user to control the notification emails, he'll be notified every time when someone will mention him.

I see 2 options:
1. We add a new event type ("On mention") and some options for the user to control when he should be notified or not. But this solution it's quite complex and it'll require more time to work on it. Also, the message from the notification emails should contain something like "You received this email because someone mentioned you".
2. We just add the user as watcher and the notifications will be controlled by the actual notification rules. In addition, we can add in the user preferences an option regarding if he wants to auto watch the objects where he is mentioned.

My proposal is to go with 2 for now and see in the future how can develop more this feature.

Anyway, another main improvement here is to have a client side feature to allow users to mention someone using an autocomplete dropdown.

Any other feedback on this is welcome.

Marius BALTEANU wrote:

...
My main concern regarding the proposed solution is that there is no way for the user to control the notification emails, he'll be notified every time when someone will mention him.
...
I see 2 options:
...
2. We just add the user as watcher and the notifications will be controlled by the actual notification rules. In addition, we can add in the user preferences an option regarding if he wants to auto watch the objects where he is mentioned.

Won't adding mentioned users as watchers cause them to get even more e-mails? Consider a scenario where developers (watching the issue) frequently adds notes to an issue. Once in a while they need to notify some stakeholder (not watching as this would cause too many irrelevant notifications) which they do by mentioning them.
Or perhaps I misunderstand - by "add the user as watcher" do you mean only for that one request (not persisting the setting)?

Anders Thomsen wrote:

Won't adding mentioned users as watchers cause them to get even more e-mails? Consider a scenario where developers (watching the issue) frequently adds notes to an issue. Once in a while they need to notify some stakeholder (not watching as this would cause too many irrelevant notifications) which they do by mentioning them.
Or perhaps I misunderstand - by "add the user as watcher" do you mean only for that one request (not persisting the setting)?

You're right, it'll generate more emails.

How do you see the implementation?

In a company there should be no problem as mentioning a user would have the same effect as sending an email to the user. So I believe the main concern would be in public websites like this one.

It could be controlled by a new permission: "Notify mentioned users". If one don't have that permission, no drop-down should be displayed typing in @ and of cause no notification e-mail should be sent.

Marius BALTEANU wrote:

My main concern regarding the proposed solution is that there is no way for the user to control the notification emails, he'll be notified every time when someone will mention him.

I think it is the ideal behavior because this feature is to forcefully send a notification to another user. Since the notification is sent only when a user used "@login" or other special markup, I think it is not a big problem.

I agree with #13919#note-47.

http://www.redmine.org/projects/redmine/repository/entry/trunk/app/models/user.rb#L790
always send to project members except when mail_notification is set to 'none'

If mail_notification is not none, a notification will be sent when the news is created(#4700).

I think that notifications when mentioned are as important as news notifications.

Marius BALTEANU wrote:

Please let me know what do you think about this.

Thank you for your activity on this Issue(feature)!
The implementation using the "acts_as_mentionable" plugin looks more beautiful than the patch implementation I attached in #13919#note-34.

Also, the email send to the user should be a new mail template, something like "You have been mentioned in #{issue} by #{user}".

That looks good.

If the mention user is always notified of changes to mentionable attribute(eg issue),
I think it would be ideal to send only the email "You have been mentioned in #{issue} by #{user}". (Do not send existing email "Issue#1 has been updated by #{user}")

Mizuki ISHIKAWA wrote:

Thank you for your activity on this Issue(feature)!
The implementation using the "acts_as_mentionable" plugin looks more beautiful than the patch implementation I attached in #13919#note-34.

Thanks for you quick feedback. Do you like to continue from here? I would be very happy to review the patch.

In Gitlab, when you mention someone, they gets automatically subscribed to the thread and receives all further updates on the issue. We use that behaviour in our company and it very well suits our needs.

Having a different paradigm in another tool is misleading. IMHO, the fact that mentioned user could be added to watcher list should be controlled via a flag in the settings. As I can see on this plugin: https://github.com/arkhitech/redmine_mentions, its a feature which has been multiple times been requested.

What's your opinion ?

De Lo wrote:

In Gitlab, when you mention someone, they gets automatically subscribed to the thread and receives all further updates on the issue. We use that behaviour in our company and it very well suits our needs.

Having a different paradigm in another tool is misleading. IMHO, the fact that mentioned user could be added to watcher list should be controlled via a flag in the settings. As I can see on this plugin: https://github.com/arkhitech/redmine_mentions, its a feature which has been multiple times been requested.

What's your opinion ?

I think the above feature to add mentioned users to watchers should be considered as an additional implementation after this feature (#13919) is committed.

Example, Add the mentioned user to watcher if Setting.add_mentioned_users_to_watchers is true.

Hi,

On track for 5.0.0 ?

Fabiano Souza wrote:

Hi,

On track for 5.0.0 ?

What the hell, I check this email every now and then "about once a year, lol". I added this 8 years ago, 8 YEARS!!! glad I stopped using Redmine about 7 years ago.

Diego Antunes wrote:

What the hell, I check this email every now and then "about once a year, lol". I added this 8 years ago, 8 YEARS!!! glad I stopped using Redmine about 7 years ago.

Diego, it's free and open-source software. And since we are not paying for its development or usage we can't really claim for anything.
We can support and encourage the developers and maintainers, but definitely not blame them. Especially, when a requested issue is not a bug, but a new feature.

PS: I'm also looking forward to this feature. And it's probably the last feature I really miss in Redmine :)

Dmitry Babenko wrote:

Diego, it's free and open-source software. And since we are not paying for its development or usage we can't really claim for anything.
We can support and encourage the developers and maintainers, but definitely not blame them. Especially, when a requested issue is not a bug, but a new feature.

Thanks for the nice words!

I'm confident that we can deliver this in 5.0.0. I've a functional version with both issues reported by Mizuki in #13919#note-59 fixed, but it depends on the newly #36162 that changes the notification reason from a static and generic text to a dynamic text.

Marius BALTEANU wrote:

I'm confident that we can deliver this in 5.0.0.

Great! Thanks! It will be a huge leap for Redmine! :)

I've a functional version with both issues reported by Mizuki in #13919#note-59 fixed, but it depends on the newly #36162 that changes the notification reason from a static and generic text to a dynamic text.

Actually, the default static email footer is just fine.
I think it is better to put #36162 for one of the future releases and not block the mentions feature if it is possible.

I agree with Dmitry here, while #36162 would be nice, mentions would definitely be more useful and should not be blocked by improvements that can be made later.

Can't wait for this one! Thx guys, you are awesome.

+

+1

I've been really waiting for this feature.
This will be a great motivation for us to update Redmine 5.
Thanks for the development!

Using the existing permission sounds good to me. If future, real usage shows that it's not optimal we could always move to a dedicated permissions. But until then I wouldn't overcomplicate things.

I think that the :mention_users "Mention Users" permission was left behind (available in the Administration section) but doesn't do anything.

Marius BALTEANU wrote in #note-79:

Feature completed!

Users mentions are now highlighted and rendered using a leading @:

Hello Marius BĂLTEANU,

In order for the user mention to work, it is necessary to have the edit task permission. Is it not possible to leave only the permission to add observers?

Hi there,

I see the discussion mentions the notion of "watcher". When mentioning an user, should that user also be added as watcher of the issue? Was the "mention feature" designed in such a way?

I observe that this doesn't happen, although the users expect this. E.g. in GitHub the purpose of mentioning, is to add as watchers.

Im not sure if anyone here ever tried/used the plugins that implemented this feature a long time ago...

You were discussing permissions and stuff while missing the point of the mentions.
Mentions are a special case, i need to know that the person mentioned gets the info... missing email config aside, i dont want redmine to check the users default email notification settings and then decide not to inform him ?

• Add an extra option to configure if i want to receive mentions-notifications
• Dont use default notification mail template, users tend to use rules to filter out notifications that do not directly address them.
• Dont list users that have no email or have notifications disabled in the User First Name User Last Name popup list
• add maybe an envelope icon next to users in that list, that will be notified by mail ( all this info is checked in mentionable.rb already, so why not use it for something good ? )

Sorry if this sounds like a rant, but you guys took 11 years to reinvent the wheel and finally came up with some square rock with a wooden stick in the middle...

Just a small addition.
To add the mentioned users as watchers on issue edit,
modify the the following code at the top of the function "self.deliver_issue_edit" in file app/models/mailer.rb :

  def self.deliver_issue_edit(journal)
    #add watchers of mentions in current change
    journal.notified_mentions.each do |user|
      issue = journal.journalized
      issue.add_watcher(user)
    end
    ...

To add the mentioned users as watchers on new issues,
modify the the following code at the top of the function "self.deliver_issue_add" in file app/models/mailer.rb :

  def self.deliver_issue_add(issue)
    #add watchers of mentions in current change
    issue.notified_mentions.each do |user|
      issue.add_watcher(user)
    end
    ...